Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional metrics and attributes for some instrumented libraries #2675

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Aug 6, 2024

Adds some additional metrics and attributes for Kafka, Amazon SQS and RabbitMQ libraries.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.00990% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (40b6ad5) to head (d5532ac).
Report is 12 commits behind head on main.

Files Patch % Lines
.../NewRelic/Agent/Core/Utilities/ExtensionsLoader.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
+ Coverage   80.80%   81.03%   +0.23%     
==========================================
  Files         459      459              
  Lines       29064    29306     +242     
  Branches     3191     3209      +18     
==========================================
+ Hits        23486    23749     +263     
+ Misses       4788     4765      -23     
- Partials      790      792       +2     
Flag Coverage Δ
Agent 81.88% <99.00%> (+0.16%) ⬆️
Profiler 73.75% <ø> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Relic/Agent/Core/Attributes/AttributeDefinition.cs 84.17% <100.00%> (+0.16%) ⬆️
...gent/Core/Attributes/AttributeDefinitionService.cs 95.57% <100.00%> (+0.30%) ⬆️
...ic/Agent/Core/Segments/MessageBrokerSegmentData.cs 97.22% <100.00%> (+4.11%) ⬆️
...nt/NewRelic/Agent/Core/Transactions/Transaction.cs 80.50% <100.00%> (ø)
...ions/NewRelic.Agent.Extensions/AwsSdk/SqsHelper.cs 90.32% <100.00%> (+28.02%) ⬆️
.../NewRelic/Agent/Core/Utilities/ExtensionsLoader.cs 16.43% <0.00%> (-0.12%) ⬇️

... and 9 files with indirect coverage changes

@tippmar-nr tippmar-nr changed the title **DRAFT** feat: Improve entity relationships for Amazon cloud services feat: Improve entity relationships for Amazon cloud services Aug 8, 2024
@tippmar-nr tippmar-nr marked this pull request as ready for review August 8, 2024 19:11
@tippmar-nr tippmar-nr requested a review from a team as a code owner August 8, 2024 19:11
@tippmar-nr tippmar-nr changed the title feat: Improve entity relationships for Amazon cloud services feat: Additional metrics and attributes for some instrumented libraries Aug 8, 2024
@tippmar-nr tippmar-nr enabled auto-merge (squash) August 8, 2024 19:28
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, everyone!

@tippmar-nr tippmar-nr merged commit a033b81 into main Aug 9, 2024
100 checks passed
@tippmar-nr tippmar-nr deleted the feature/apm-aws-relationships branch August 9, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants