Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCSampler - CountData calculated as negative causes exception #265

Closed
lspangler584 opened this issue Sep 30, 2020 · 1 comment
Closed

GCSampler - CountData calculated as negative causes exception #265

lspangler584 opened this issue Sep 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@lspangler584
Copy link
Contributor

Description
When GCSampler tries to create a negative count metric the GCSampler shuts down.

Expected Behavior
Unclear why there would be a negative value, but even if it occurs the GCSampler should not shut down.

Steps to Reproduce
No repro available.

Recommendation
Since many of the count values are delta values from the prior value, intercept a negative value and record it as 0 in the event.
When doing so, add a log message (finest) indicating the Metric and requested value that was switched to 0.

Your Environment
GCSampler is used for .NET Framework applications. It is unclear but likely this is also an issue for the GCSamplerNetCore.

@lspangler584 lspangler584 added the bug Something isn't working label Sep 30, 2020
@lspangler584
Copy link
Contributor Author

Duplicate of #264

@lspangler584 lspangler584 marked this as a duplicate of #264 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant