-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade Wix to v5 to fix an issue with non-elevated installs. #2471
Conversation
src/Agent/MsiInstaller/InstallerActions/InstallerActions.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable to me. Do we still have testing to do or do you think we're in good shape?
@nrcventura had a good point -- we should make sure Dependabot is scanning the installer directory to catch new versions of WiX, since it's only a NuGet package now. I'm not positive it'll scan |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
+ Coverage 80.43% 80.59% +0.15%
==========================================
Files 450 459 +9
Lines 27945 28777 +832
Branches 3023 3184 +161
==========================================
+ Hits 22478 23193 +715
- Misses 4691 4800 +109
- Partials 776 784 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Upgrades our Wixtoolset version for v3 to v5 to resolve a problem in that version with non-elevated installs.
As part of this change:
Updates dependabot to check the MSI nugets.
Author Checklist
Reviewer Checklist