feat: Allow the agent to run in environments with read-only filesystems #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New option to disable logging * Env var for console logging * Supportability metric if logging fails * Don't allow audit logging if logging is disabled
Co-authored-by: nr-ahemsath <nr-ahemsath@users.noreply.github.com>
…nabled (#2076) * Checkpoint in order to switch branches * Refactored AgentLogFile Moved AgentLogFile to the fixtures instead of the applications * Shorten some names * Fix bug caused by Visual Studio autocorrect * WIP * Working tests for logging disabled * Working console logging tests * Fix nuget package warnings-as-errors * Fix GuidConfigurationTests EndsWith() fails if the profiler logs the version, e.g. New Relic .NET CoreCLR Agent v10.18.0.26. Use Contains() instead
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
+ Coverage 81.05% 81.09% +0.03%
==========================================
Files 395 395
Lines 24695 24711 +16
Branches 2966 2969 +3
==========================================
+ Hits 20017 20039 +22
+ Misses 3891 3888 -3
+ Partials 787 784 -3
|
tippmar-nr
reviewed
Nov 20, 2023
tests/Agent/UnitTests/Core.UnitTest/NewRelic.Agent.Core.FromLegacy/LoggerBootstrapperTest.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Nov 20, 2023
tests/Agent/UnitTests/Core.UnitTest/NewRelic.Agent.Core.FromLegacy/LoggerBootstrapperTest.cs
Outdated
Show resolved
Hide resolved
nrcventura
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a set of features intended to make it possible and more convenient to use the agent in environments with read-only filesystems: