Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notice: The transactionTracer.stackTraceThreshold setting has been de… #1896

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Sep 8, 2023

Description

  • The transactionTracer.stackTraceThreshold setting has been deprecated and no longer has any effect.
  • Did not add a log message since it would never show up since nothing calls the setting.
  • It has not had any effect since at least 8.28.
  • Removed all tests and other bits except for the listing in the XSD which can be removed in a major release.

Closes #1026

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Merging #1896 (4ae95b1) into main (13d0989) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
- Coverage   83.39%   83.39%   -0.01%     
==========================================
  Files         402      402              
  Lines       24696    24694       -2     
==========================================
- Hits        20596    20594       -2     
  Misses       4100     4100              
Files Changed Coverage Δ
...c/Agent/Core/Configuration/DefaultConfiguration.cs 92.65% <ø> (-0.01%) ⬇️
.../Agent/Core/Configuration/ReportedConfiguration.cs 99.05% <ø> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

@jaffinito jaffinito merged commit 20ab0e7 into main Sep 8, 2023
@jaffinito jaffinito deleted the other/deprecate-stackTraceThreshold branch September 8, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to log deprecation/removal warning for the config property "transactionTracer.stackTraceThreshold"
4 participants