Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the retained file count limit for Agent log files. #1879

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

tippmar-nr
Copy link
Member

Removes the 4-file limit on retained Agent log files. Logs will still roll at 50MB, but an unlimited number will be retained.

Resolves #1878

@tippmar-nr tippmar-nr changed the title fix: Remove the file count limit restriction for Agent log files. fix: Remove the retained file count limit for Agent log files. Aug 31, 2023
@tippmar-nr tippmar-nr disabled auto-merge August 31, 2023 16:10
@tippmar-nr tippmar-nr enabled auto-merge (squash) August 31, 2023 16:10
@codecov-commenter
Copy link

Codecov Report

Merging #1879 (6302bb3) into main (a78abc9) will increase coverage by 0.04%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   83.44%   83.48%   +0.04%     
==========================================
  Files         402      402              
  Lines       24670    24670              
==========================================
+ Hits        20585    20596      +11     
+ Misses       4085     4074      -11     
Files Changed Coverage Δ
...ic/Agent/Core/DataTransport/Client/NRHttpClient.cs 73.33% <100.00%> (+4.10%) ⬆️
...t/Core/DataTransport/Client/NRHttpClientFactory.cs 100.00% <100.00%> (+100.00%) ⬆️
.../NewRelic/Agent/Core/Logging/LoggerBootstrapper.cs 81.08% <100.00%> (ø)

... and 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit e49250a into main Aug 31, 2023
@tippmar-nr tippmar-nr deleted the other/update-log-file-retention-limit branch August 31, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only the 4 most recent Agent log files are retained
5 participants