-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Serilog.Extensions.Logging and NLog.Extensions.Logging #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
reviewed
Aug 23, 2023
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Logging/LogProviders.cs
Outdated
Show resolved
Hide resolved
chynesNR
commented
Aug 23, 2023
...lic/Agent/Extensions/Providers/Wrapper/MicrosoftExtensionsLogging/MicrosoftLoggingWrapper.cs
Show resolved
Hide resolved
nrcventura
reviewed
Aug 23, 2023
...lic/Agent/Extensions/Providers/Wrapper/MicrosoftExtensionsLogging/MicrosoftLoggingWrapper.cs
Outdated
Show resolved
Hide resolved
nrcventura
reviewed
Aug 23, 2023
...lic/Agent/Extensions/Providers/Wrapper/MicrosoftExtensionsLogging/MicrosoftLoggingWrapper.cs
Show resolved
Hide resolved
nr-ahemsath
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I appreciate all of the comments to help understand what is going on. 👍
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 83.57% 83.44% -0.13%
==========================================
Files 389 402 +13
Lines 24504 24670 +166
==========================================
+ Hits 20478 20586 +108
- Misses 4026 4084 +58
|
nrcventura
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we detected Microsoft.Extensions.Logging and another logger, we would only instrument MEL, in order to avoid double collection of logs. This turned out to be a flawed approach, because MEL does not store any context data. It relies on the underlying logger to handle it. So now, if we detect that scenario, we disable MEL instrumentation. Only if we don't find another logger that we know how to instrument, will we instrument MEL.
In order for us to collect context data from an ILogger via MEL, the logger must implement
IExternalScopeProvider
(specifically theForEachScope
function). Scope data can be any object, but we will only collect it if it's a key-value pair (or collection of key-value pairs). This is how NLog and Serilog implement their scope provider, so this seems like a reasonable restriction.I also found that NLog treats context data and scope data differently. We weren't recording NLog's scope data at all before; now we are.
Addresses #1859
Author Checklist
Reviewer Checklist