diff --git a/src/Agent/NewRelic/Agent/Core/Config/ConfigurationLoader.cs b/src/Agent/NewRelic/Agent/Core/Config/ConfigurationLoader.cs index 2353f7b1f9..12752eb61f 100644 --- a/src/Agent/NewRelic/Agent/Core/Config/ConfigurationLoader.cs +++ b/src/Agent/NewRelic/Agent/Core/Config/ConfigurationLoader.cs @@ -4,6 +4,7 @@ using NewRelic.Agent.Core.Events; using NewRelic.Agent.Core.Utilities; using NewRelic.Core; +using NewRelic.Agent.Core.Configuration; using NewRelic.Core.Logging; using NewRelic.SystemInterfaces; using System; @@ -15,7 +16,6 @@ using System.Xml.Serialization; #if NETSTANDARD2_0 using System.Reflection; -using NewRelic.Agent.Core.Configuration; #endif namespace NewRelic.Agent.Core.Config @@ -139,7 +139,7 @@ public static string GetAgentConfigFileName() if (fileName != null) return fileName; - throw new Exception(string.Format("Could not find {0} in NewRelic.ConfigFile path, application root, New Relic home directory, or working directory.", NewRelicConfigFileName)); + throw new Exception(string.Format("Could not find {0} in {1} path, application root, New Relic home directory, or working directory.", NewRelicConfigFileName, Constants.AppSettingsConfigFile)); } private static string TryGetAgentConfigFileFromAppConfig() @@ -149,13 +149,13 @@ private static string TryGetAgentConfigFileFromAppConfig() try { - var fileName = AppSettingsConfigResolveWhenUsed.GetAppSetting("NewRelic.ConfigFile"); + var fileName = AppSettingsConfigResolveWhenUsed.GetAppSetting(Constants.AppSettingsConfigFile); if (!File.Exists(fileName)) { return null; } - Log.Info("Configuration file found in path pointed to by NewRelic.ConfigFile appSetting: {0}", fileName); + Log.Info("Configuration file found in path pointed to by {0} appSetting: {1}", Constants.AppSettingsConfigFile, fileName); return fileName; } catch (Exception) @@ -166,13 +166,13 @@ private static string TryGetAgentConfigFileFromAppConfig() #else try { - var fileName = GetConfigSetting("NewRelic.ConfigFile").Value; + var fileName = GetConfigSetting(Constants.AppSettingsConfigFile).Value; if (!FileExists(fileName)) { return null; } - Log.Info("Configuration file found in path pointed to by NewRelic.ConfigFile appSetting of app/web config: {0}", fileName); + Log.Info("Configuration file found in path pointed to by {0} appSetting of app/web config: {1}", Constants.AppSettingsConfigFile, fileName); return fileName; } catch (Exception) @@ -674,7 +674,7 @@ public configuration Initialize(string xml, string provenance) try { - var enabledProvenance = ConfigurationLoader.GetConfigSetting("NewRelic.AgentEnabled"); + var enabledProvenance = ConfigurationLoader.GetConfigSetting(Constants.AppSettingsAgentEnabled); if (enabledProvenance != null && enabledProvenance.Value != null && bool.Parse(enabledProvenance.Value) == false) { agentEnabled = false; @@ -683,7 +683,7 @@ public configuration Initialize(string xml, string provenance) } catch { - Log.Error("Failed to read NewRelic.AgentEnabled from local config."); + Log.Error($"Failed to read {Constants.AppSettingsAgentEnabled} from local config."); } return this; diff --git a/src/Agent/NewRelic/Agent/Core/Configuration/AppSettingsConfigResolveWhenUsed.cs b/src/Agent/NewRelic/Agent/Core/Configuration/AppSettingsConfigResolveWhenUsed.cs index 2a168cc0b6..20bbadae75 100644 --- a/src/Agent/NewRelic/Agent/Core/Configuration/AppSettingsConfigResolveWhenUsed.cs +++ b/src/Agent/NewRelic/Agent/Core/Configuration/AppSettingsConfigResolveWhenUsed.cs @@ -5,6 +5,7 @@ using System; using System.IO; using Microsoft.Extensions.Configuration; +using NewRelic.Core; using NewRelic.Core.Logging; namespace NewRelic.Agent.Core.Configuration @@ -79,6 +80,10 @@ public static string GetAppSetting(string key) } else { + if (key.Equals(Constants.AppSettingsLicenseKey)) + { + value = Strings.ObfuscateLicenseKey(value); + } Log.Debug($"Reading value from appsettings.json and appsettings.*.json: '{key}={value}'"); } } diff --git a/src/Agent/NewRelic/Agent/Core/Configuration/Constants.cs b/src/Agent/NewRelic/Agent/Core/Configuration/Constants.cs new file mode 100644 index 0000000000..a2efacb984 --- /dev/null +++ b/src/Agent/NewRelic/Agent/Core/Configuration/Constants.cs @@ -0,0 +1,15 @@ +// Copyright 2020 New Relic, Inc. All rights reserved. +// SPDX-License-Identifier: Apache-2.0 + +namespace NewRelic.Agent.Core.Configuration +{ + public static class Constants + { + public const string AppSettingsLicenseKey = "NewRelic.LicenseKey"; + public const string AppSettingsAgentEnabled = "NewRelic.AgentEnabled"; + public const string AppSettingsAppName = "NewRelic.AppName"; + public const string AppSettingsLabels = "NewRelic.Labels"; + public const string AppSettingsConfigFile = "NewRelic.ConfigFile"; + + } +} diff --git a/src/Agent/NewRelic/Agent/Core/Configuration/DefaultConfiguration.cs b/src/Agent/NewRelic/Agent/Core/Configuration/DefaultConfiguration.cs index 5904a62a1e..7c500156a9 100644 --- a/src/Agent/NewRelic/Agent/Core/Configuration/DefaultConfiguration.cs +++ b/src/Agent/NewRelic/Agent/Core/Configuration/DefaultConfiguration.cs @@ -198,7 +198,7 @@ public virtual bool AgentEnabled { lock (_lockObj) { - _agentEnabledAppSettingParsed ??= bool.TryParse(_configurationManagerStatic.GetAppSetting("NewRelic.AgentEnabled"), + _agentEnabledAppSettingParsed ??= bool.TryParse(_configurationManagerStatic.GetAppSetting(Constants.AppSettingsAgentEnabled), out _appSettingAgentEnabled); } } @@ -216,7 +216,7 @@ public virtual string AgentLicenseKey if (_agentLicenseKey != null) return _agentLicenseKey; - _agentLicenseKey = _configurationManagerStatic.GetAppSetting("NewRelic.LicenseKey") + _agentLicenseKey = _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLicenseKey) ?? EnvironmentOverrides(_localConfiguration.service.licenseKey, "NEW_RELIC_LICENSE_KEY", "NEWRELIC_LICENSEKEY"); if (_agentLicenseKey != null) @@ -243,7 +243,7 @@ private IEnumerable GetApplicationNames() return runtimeAppNames; } - var appName = _configurationManagerStatic.GetAppSetting("NewRelic.AppName"); + var appName = _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName); if (appName != null) { Log.Info("Application name from web.config or app.config."); @@ -1361,7 +1361,7 @@ public virtual string Labels { if (!_labelsChecked) { - var labels = _configurationManagerStatic.GetAppSetting("NewRelic.Labels"); + var labels = _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLabels); if (labels != null) { Log.Info("Application labels from web.config, app.config, or appsettings.json."); diff --git a/tests/Agent/UnitTests/CompositeTests/CompositeTestAgent.cs b/tests/Agent/UnitTests/CompositeTests/CompositeTestAgent.cs index c96caa65ab..146abfff65 100644 --- a/tests/Agent/UnitTests/CompositeTests/CompositeTestAgent.cs +++ b/tests/Agent/UnitTests/CompositeTests/CompositeTestAgent.cs @@ -141,7 +141,7 @@ public CompositeTestAgent(bool shouldAllowThreads, bool includeAsyncLocalStorage .DoInstead(callback => { lock (_queuedCallbacksLockObject) { _queuedCallbacks.Add(callback); } }); var configurationManagerStatic = Mock.Create(); - Mock.Arrange(() => configurationManagerStatic.GetAppSetting("NewRelic.LicenseKey")) + Mock.Arrange(() => configurationManagerStatic.GetAppSetting(NewRelic.Agent.Core.Configuration.Constants.AppSettingsLicenseKey)) .Returns("Composite test license key"); // Construct services diff --git a/tests/Agent/UnitTests/Core.UnitTest/Config/ConfigurationLoaderTests.cs b/tests/Agent/UnitTests/Core.UnitTest/Config/ConfigurationLoaderTests.cs index fcdd3172f0..33b0956344 100644 --- a/tests/Agent/UnitTests/Core.UnitTest/Config/ConfigurationLoaderTests.cs +++ b/tests/Agent/UnitTests/Core.UnitTest/Config/ConfigurationLoaderTests.cs @@ -1,4 +1,4 @@ -// Copyright 2020 New Relic, Inc. All rights reserved. +// Copyright 2020 New Relic, Inc. All rights reserved. // SPDX-License-Identifier: Apache-2.0 #if NETFRAMEWORK @@ -11,6 +11,7 @@ using System.Text; using System.Threading.Tasks; using System.Web; +using NewRelic.Agent.Core.Configuration; using NUnit.Framework; namespace NewRelic.Agent.Core.Config @@ -119,7 +120,7 @@ public void GetAgentConfigFileName_ReturnsConfigFileFromAppConfig() { const string expectedFileName = "filenameFromAppConfig"; var testWebConfiguration = ConfigurationManager.OpenExeConfiguration(null); - testWebConfiguration.AppSettings.Settings.Add("NewRelic.ConfigFile", expectedFileName); + testWebConfiguration.AppSettings.Settings.Add(Constants.AppSettingsConfigFile, expectedFileName); staticMocks.UseAppDomainAppIdFunc(() => "testAppId"); staticMocks.UseAppDomainAppVirtualPathFunc(() => "testVirtualPath"); @@ -138,7 +139,7 @@ public void TryGetAgentConfigFileFromAppConfig_ReturnsNullWhenFileDoesNotExist() { const string expectedFileName = "filenameFromAppConfig"; var testWebConfiguration = ConfigurationManager.OpenExeConfiguration(null); - testWebConfiguration.AppSettings.Settings.Add("NewRelic.ConfigFile", expectedFileName); + testWebConfiguration.AppSettings.Settings.Add(Constants.AppSettingsConfigFile, expectedFileName); staticMocks.UseAppDomainAppIdFunc(() => "testAppId"); staticMocks.UseAppDomainAppVirtualPathFunc(() => "testVirtualPath"); @@ -157,7 +158,7 @@ public void TryGetAgentConfigFileFromAppConfig_ReturnsNullOnException() { const string expectedFileName = "filenameFromAppConfig"; var testWebConfiguration = ConfigurationManager.OpenExeConfiguration(null); - testWebConfiguration.AppSettings.Settings.Add("NewRelic.ConfigFile", expectedFileName); + testWebConfiguration.AppSettings.Settings.Add(Constants.AppSettingsConfigFile, expectedFileName); staticMocks.UseAppDomainAppIdFunc(() => "testAppId"); staticMocks.UseAppDomainAppVirtualPathFunc(() => "testVirtualPath"); diff --git a/tests/Agent/UnitTests/Core.UnitTest/Configuration/DefaultConfigurationTests.cs b/tests/Agent/UnitTests/Core.UnitTest/Configuration/DefaultConfigurationTests.cs index 0b3d2f4759..7bf49e545c 100644 --- a/tests/Agent/UnitTests/Core.UnitTest/Configuration/DefaultConfigurationTests.cs +++ b/tests/Agent/UnitTests/Core.UnitTest/Configuration/DefaultConfigurationTests.cs @@ -7,6 +7,7 @@ using System.Linq; using System.Xml.Serialization; using NewRelic.Agent.Core.Config; +using NewRelic.Agent.Core.Configuration; using NewRelic.Agent.Core.DataTransport; using NewRelic.SystemInterfaces; using NewRelic.SystemInterfaces.Web; @@ -75,18 +76,18 @@ public void AgentEnabledShouldPassThroughToLocalConfig() [Test] public void AgentEnabledShouldUseCachedAppSetting() { - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AgentEnabled")).Returns("false"); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAgentEnabled)).Returns("false"); Assert.IsFalse(_defaultConfig.AgentEnabled); Assert.IsFalse(_defaultConfig.AgentEnabled); - Mock.Assert(() => _configurationManagerStatic.GetAppSetting("NewRelic.AgentEnabled"), Occurs.Once()); + Mock.Assert(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAgentEnabled), Occurs.Once()); } [Test] public void AgentEnabledShouldPreferAppSettingOverLocalConfig() { - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AgentEnabled")).Returns("false"); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAgentEnabled)).Returns("false"); _localConfig.agentEnabled = true; @@ -1384,7 +1385,7 @@ public void TransactionEventUsesDefaultWhenNoConfigValues() public string LabelsAreOverriddenProperlyAndAreCached(string appConfigValue, string environment, string local) { _localConfig.labels = local; - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.Labels")).Returns(appConfigValue); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLabels)).Returns(appConfigValue); Mock.Arrange(() => _environment.GetEnvironmentVariable("NEW_RELIC_LABELS")).Returns(environment); // call Labels accessor multiple times to verify caching behavior @@ -1395,7 +1396,7 @@ public string LabelsAreOverriddenProperlyAndAreCached(string appConfigValue, str } // Checking that the underlying abstractions are only ever called once verifies caching behavior - Mock.Assert(() => _configurationManagerStatic.GetAppSetting("NewRelic.Labels"), Occurs.AtMost(1)); + Mock.Assert(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLabels), Occurs.AtMost(1)); Mock.Assert(() => _environment.GetEnvironmentVariable("NEW_RELIC_LABELS"), Occurs.AtMost(1)); return result; @@ -1434,7 +1435,7 @@ public string LicenseKeyEnvironmentOverridesLocal(string appSettingEnvironmentNa _localConfig.service.licenseKey = local; Mock.Arrange(() => _environment.GetEnvironmentVariable("NEW_RELIC_LICENSE_KEY")).Returns(newEnvironmentName); Mock.Arrange(() => _environment.GetEnvironmentVariable("NEWRELIC_LICENSEKEY")).Returns(legacyEnvironmentName); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.LicenseKey")).Returns(appSettingEnvironmentName); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLicenseKey)).Returns(appSettingEnvironmentName); return _defaultConfig.AgentLicenseKey; } @@ -1764,7 +1765,7 @@ public void ApplicationNamesThrowsIfNoAppNameFound() //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); _localConfig.application.name = new List(); @@ -1778,8 +1779,7 @@ public void ApplicationNamesThrowsIfNoAppNameFound() public void ApplicationNamesPullsNamesFromRuntimeConfig() { _runTimeConfig.ApplicationNames = new List { "MyAppName1", "MyAppName2" }; - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns((string)null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns((string)null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns((string)null); Mock.Arrange(() => _environment.GetEnvironmentVariable("IISEXPRESS_SITENAME")).Returns((string)null); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns((string)null); _localConfig.application.name = new List(); @@ -1799,7 +1799,7 @@ public void ApplicationNamesPullsNamesFromRuntimeConfig() public void ApplicationNamesPullsSingleNameFromAppSettings() { _runTimeConfig.ApplicationNames = new List(); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns("MyAppName"); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns("MyAppName"); Mock.Arrange(() => _environment.GetEnvironmentVariable("IISEXPRESS_SITENAME")).Returns("OtherAppName"); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("OtherAppName"); _localConfig.application.name = new List(); @@ -1818,7 +1818,7 @@ public void ApplicationNamesPullsSingleNameFromAppSettings() public void ApplicationNamesPullsMultipleNamesFromAppSettings() { _runTimeConfig.ApplicationNames = new List(); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns("MyAppName1,MyAppName2"); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns("MyAppName1,MyAppName2"); Mock.Arrange(() => _environment.GetEnvironmentVariable("IISEXPRESS_SITENAME")).Returns("OtherAppName"); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("OtherAppName"); _localConfig.application.name = new List(); @@ -1838,7 +1838,7 @@ public void ApplicationNamesPullsMultipleNamesFromAppSettings() public void ApplicationNamesPullsSingleNameFromIisExpressSitenameEnvironmentVariable() { _runTimeConfig.ApplicationNames = new List(); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns((string)null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns((string)null); Mock.Arrange(() => _environment.GetEnvironmentVariable("IISEXPRESS_SITENAME")).Returns("MyAppName"); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("OtherAppName"); _localConfig.application.name = new List(); @@ -1857,7 +1857,7 @@ public void ApplicationNamesPullsSingleNameFromIisExpressSitenameEnvironmentVari public void ApplicationNamesPullsMultipleNamesFromIisExpressSitenameEnvironmentVariaible() { _runTimeConfig.ApplicationNames = new List(); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns((string)null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns((string)null); Mock.Arrange(() => _environment.GetEnvironmentVariable("IISEXPRESS_SITENAME")).Returns("MyAppName1,MyAppName2"); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("OtherAppName"); _localConfig.application.name = new List(); @@ -1881,7 +1881,7 @@ public void ApplicationNamesPullsSingleNameFromRoleNameEnvironmentVariaible() //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("MyAppName"); _localConfig.application.name = new List(); @@ -1904,7 +1904,7 @@ public void ApplicationNamesPullsMultipleNamesFromRoleNameEnvironmentVariaible() //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); Mock.Arrange(() => _environment.GetEnvironmentVariable("RoleName")).Returns("MyAppName1,MyAppName2"); _localConfig.application.name = new List(); @@ -1928,7 +1928,7 @@ public void ApplicationNamesPullsNamesFromNewRelicConfig() //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); _localConfig.application.name = new List { "MyAppName1", "MyAppName2" }; Mock.Arrange(() => _environment.GetEnvironmentVariable("APP_POOL_ID")).Returns("OtherAppName"); @@ -1951,7 +1951,7 @@ public void ApplicationNamesPullsSingleNameFromAppPoolIdEnvironmentVariaible() //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns((string)null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns((string)null); _localConfig.application.name = new List(); Mock.Arrange(() => _environment.GetEnvironmentVariable("APP_POOL_ID")).Returns("MyAppName"); @@ -1973,7 +1973,7 @@ public void ApplicationNamesPullsMultipleNamesFromAppPoolIdEnvironmentVariaible( //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); _localConfig.application.name = new List(); Mock.Arrange(() => _environment.GetEnvironmentVariable("APP_POOL_ID")).Returns("MyAppName1,MyAppName2"); @@ -2001,7 +2001,7 @@ public void ApplicationNamesPullsSingleNameFromAppPoolIdFromCommandLine(string e //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); _localConfig.application.name = new List(); Mock.Arrange(() => _environment.GetCommandLineArgs()).Returns(commandLine.Split(new[] { ' ' })); @@ -2022,7 +2022,7 @@ public void ApplicationNamesPullsNameFromProcessIdIfAppDomainAppVirtualPathIsNul //Sets to default return null for all calls unless overriden by later arrange. Mock.Arrange(() => _environment.GetEnvironmentVariable(Arg.IsAny())).Returns(null); - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.AppName")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsAppName)).Returns(null); _localConfig.application.name = new List(); diff --git a/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/DataTransport/CollectorHostNameTests.cs b/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/DataTransport/CollectorHostNameTests.cs index 173ad151ae..66f68d364c 100644 --- a/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/DataTransport/CollectorHostNameTests.cs +++ b/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/DataTransport/CollectorHostNameTests.cs @@ -69,7 +69,7 @@ public void Setup() [TestCaseSource("CollectorHostnameTestData")] public void RunCrossAgentCollectorHostnameTests(string configFileKey, string envKey, string configOverrideHost, string envOverrideHost, string hostname) { - Mock.Arrange(() => _configurationManagerStatic.GetAppSetting("NewRelic.LicenseKey")).Returns(null); + Mock.Arrange(() => _configurationManagerStatic.GetAppSetting(Constants.AppSettingsLicenseKey)).Returns(null); if (envKey != null) { diff --git a/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/RumTests/RumClientConfigTests.cs b/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/RumTests/RumClientConfigTests.cs index 46c8ef675f..95f1f3fe9b 100644 --- a/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/RumTests/RumClientConfigTests.cs +++ b/tests/Agent/UnitTests/Core.UnitTest/CrossAgentTests/RumTests/RumClientConfigTests.cs @@ -95,7 +95,7 @@ private void SetUp(TestCase testCase) _localConfig.crossApplicationTracingEnabled = true; _localConfig.attributes.enabled = true; _localConfig.service.licenseKey = testCase.LicenseKey; - _localConfig.appSettings.Add(new configurationAdd() { key = "NewRelic.LicenseKey", value = testCase.LicenseKey }); + _localConfig.appSettings.Add(new configurationAdd() { key = Constants.AppSettingsLicenseKey, value = testCase.LicenseKey }); _serverConfig.RumSettingsJavaScriptAgentLoader = "JSAGENT"; _serverConfig.RumSettingsJavaScriptAgentFile = testCase.ConnectReply.JsAgentFile; _serverConfig.RumSettingsBeacon = testCase.ConnectReply.Beacon;