Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nrdb): update to nrdb query to include more options #1110

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Mar 12, 2024

Issue Fixed

#1093

Summary

The current query function in the nrdb package only has options accountId and query, while the request put forth in the issue linked above is to also expose the option timeout. Hence, this PR proposes the following changes -

  • add options timeout and async which are present in the query's fields in the API
  • add tests accordingly
  • beautify the nrdb package to make it look cleaner

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.89%. Comparing base (228db82) to head (f677c2e).

Files Patch % Lines
pkg/nrdb/nrdb_query.go 80.76% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1110       +/-   ##
===========================================
+ Coverage   38.90%   68.89%   +29.98%     
===========================================
  Files          86      104       +18     
  Lines        5590     6363      +773     
===========================================
+ Hits         2175     4384     +2209     
+ Misses       3249     1645     -1604     
- Partials      166      334      +168     
Flag Coverage Δ
integration 61.02% <80.76%> (?)
unit 38.84% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic pranav-new-relic marked this pull request as ready for review March 18, 2024 03:53
@pranav-new-relic pranav-new-relic merged commit b25f93d into main Mar 18, 2024
10 checks passed
@pranav-new-relic pranav-new-relic deleted the nrdb-query-update branch March 18, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants