fix(GenericEntityOutline): addition of tags to attributes returned #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 41.30% 41.30%
=======================================
Files 79 79
Lines 4995 4995
=======================================
Hits 2063 2063
Misses 2784 2784
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Comment on lines
+2108
to
+2111
| tags { | ||
| key | ||
| values | ||
| } |
There was a problem hiding this comment.
blank comment to allow GitHub to display this file
sanderblue
approved these changes
Aug 23, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the addition of tags to GenericEntityOutline in order to make tags accessible by Terraform, which is needed to facilitate a change in the Terraform Provider to the data source newrelic_synthetics_private_location, in which the key of a private location is to be retrieved from the tags returned.
(note: given that Tutone is running into errors when trying to refetch the
entitiespackage, this change has been manually added).unblocks
newrelic/terraform-provider-newrelic#2446
newrelic/terraform-provider-newrelic#2453 (same PR but reopened)