Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message: "Security layer: requested 3, selected 1" #1974

Closed
buhtz opened this issue Aug 26, 2021 · 2 comments · Fixed by #1975
Closed

Improve log message: "Security layer: requested 3, selected 1" #1974

buhtz opened this issue Aug 26, 2021 · 2 comments · Fixed by #1975

Comments

@buhtz
Copy link

buhtz commented Aug 26, 2021

Xrdp's log (0.9.12-1 from Debian 11 stable) often has entries like this

Security layer: requested 0, selected 1

Security layer: requested 3, selected 1

It is unclear what it means. We do not need the answer here in this Issue but in the log itself.

Please clarify the log message that it can be understood by the user/admin who reads the log messages.

@metalefty
Copy link
Member

Indeed, that should be improved.

@matt335672
Copy link
Member

Log messages can only be read by admins.

I've written a quick PR to log the negotiated security level as text strings as-per [MS-RDPBCGR] 2.2.1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants