Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Ensure Neutrino and presets function properly on commit #58

Closed
eliperelman opened this issue Feb 25, 2017 · 2 comments
Closed

Ensure Neutrino and presets function properly on commit #58

eliperelman opened this issue Feb 25, 2017 · 2 comments
Labels
core

Comments

@eliperelman
Copy link
Member

eliperelman commented Feb 25, 2017 •
edited
Loading

Following a faulty review on a Jest preset PR, it's clear that we need a more robust mechanism for ensuring things function properly before commit and publish. This should involve tests or actually running the presets in CI and verifying they don't throw non-zero exits or both.
@eliperelman eliperelman added this to the v5 milestone Mar 3, 2017
@eliperelman
Copy link
Member Author

Partially resolved in #86. Need to add some more tests for other presets and middleware.

@edmorley edmorley mentioned this issue Mar 9, 2017
Merged
@eliperelman eliperelman removed this from the v5 milestone Mar 24, 2017
@eliperelman
Copy link
Member Author

All packages now have rudimentary tests with #256.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eliperelman