Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get raw data endpoints #74

Merged
merged 6 commits into from
Nov 17, 2020
Merged

Conversation

pgrill
Copy link
Collaborator

@pgrill pgrill commented Nov 11, 2020

  • Add the /reports/{camera_id}/daily_data endpoint to retrieve the daily CSV file without any analysis
  • Include the webhooks support in loggers
  • Refactor the loggers removing unused code.

libs/loggers/csv_logger.py Outdated Show resolved Hide resolved
version=LOG_FORMAT_VERSION
)
if self.web_hook_logger:
self.web_hook_logger.log_objects(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these two loggers have a log_objects function with the same signature, I am tempted to do something like this:

for logger in [logger1, logger2]:
    logger.log_objects(...)

That would be nice if you plan to support multiple loggers, otherwise might not be that helpful.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a good idea.

I changed the logger implementation structure following the pattern you suggested.

libs/loggers/csv_logger.py Outdated Show resolved Hide resolved
config-jetson.ini Show resolved Hide resolved
@pgrill pgrill force-pushed the Get-Raw-Data-Endpoints branch from 125904e to 9c1ce88 Compare November 13, 2020 13:52
@pgrill pgrill merged commit 1665cbe into galliot-us:master Nov 17, 2020
@pgrill pgrill deleted the Get-Raw-Data-Endpoints branch November 17, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants