-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get raw data endpoints #74
Conversation
libs/loggers/loggers.py
Outdated
version=LOG_FORMAT_VERSION | ||
) | ||
if self.web_hook_logger: | ||
self.web_hook_logger.log_objects( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As these two loggers have a log_objects function with the same signature, I am tempted to do something like this:
for logger in [logger1, logger2]:
logger.log_objects(...)
That would be nice if you plan to support multiple loggers, otherwise might not be that helpful.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a good idea.
I changed the logger implementation structure following the pattern you suggested.
125904e
to
9c1ce88
Compare
/reports/{camera_id}/daily_data
endpoint to retrieve the daily CSV file without any analysis