Tests api processor routers #105

JFer11 · 2020-12-21T20:04:47Z

In this branch, first endpoints tests were added.
All "app" and "config" router endpoints were tested with pytest.

api/tests/app/test_app.py

pgrill · 2020-12-22T12:18:38Z

api/tests/app/test_app.py

+        expected_response = get_app_from_ini_config_file_json(config_sample_path)
+        expected_response["dashboardurl"] = expected_response["dashboard_url"]
+        del expected_response["dashboard_url"]
+


Why is this change required?

I tested the endpoint /app and it returns the key "dashboard_url"

I am not sure about that, in my case, when i debug, the endpoint returns the key "dashboardurl". However, my function get_app_from_ini_config_file_json, returns all the keys fine, less "dashboard_url", so we have to change it manually.

pgrill · 2020-12-22T12:21:24Z

api/tests/app/test_app.py

+            assert response.status_code == 200
+            expected_response = expected_response_function(config_sample_path)
+            assert response.json() == expected_response
+        elif correct_type == "integer":


Is missing the correct_type == "integer" case?

I think you meant the "bool" case, I made it explicit now.

pgrill · 2020-12-22T12:22:32Z

api/tests/app/test_app.py

+        response = client.put('/app', json=body)
+
+        expected_response = expected_response_function(config_sample_path)
+        expected_response_2 = expected_response_default()


Maybe we can rename the variable as default_response?

renzodgc · 2021-01-18T14:11:31Z

api/tests/README.md

@@ -0,0 +1,10 @@
+###How tests were built
+
+To further improve the tests, I made this file to easily understand how they worked.


Suggested change

To further improve the tests, I made this file to easily understand how they worked.

This file aims to clarify how the unitary test work.

renzodgc · 2021-01-18T14:11:43Z

api/tests/README.md

+
+To further improve the tests, I made this file to easily understand how they worked.
+
+The main thing to know is to understand what role fixtures play, especially Config_rollback. 


Suggested change

The main thing to know is to understand what role fixtures play, especially Config_rollback.

The main thing to know is to understand what role fixtures play, especially `Config_rollback`.

Is there another thing to clarify or just Config_rollback?

No, just Config_rollback

renzodgc · 2021-01-18T14:12:27Z

api/tests/README.md

+
+The main thing to know is to understand what role fixtures play, especially Config_rollback. 
+
+Config_rollback fixture does the following:


Suggested change

Config_rollback fixture does the following:

The `Config_rollback` fixture does the following:

renzodgc · 2021-01-18T14:13:20Z

api/tests/README.md

+The main thing to know is to understand what role fixtures play, especially Config_rollback. 
+
+Config_rollback fixture does the following:
+1. setUp: Initialize the app with a different config file (the one with template in the name).


Suggested change

1. setUp: Initialize the app with a different config file (the one with template in the name).

1. `setUp`: Initializes the app with a different config file (given from the name of an actual config file).

renzodgc · 2021-01-18T14:52:44Z

api/tests/README.md

+
+Config_rollback fixture does the following:
+1. setUp: Initialize the app with a different config file (the one with template in the name).
+2. Returns the client to make the request and also returns the root of the config file. That root is also returned in order to go directly to that file and check if the changes made from our endpoints were valid.


Does root mean path? or its content? I presume is the path

Suggested change

2. Returns the client to make the request and also returns the root of the config file. That root is also returned in order to go directly to that file and check if the changes made from our endpoints were valid.

2. Returns the client to make the request and also the root of the config file. The latter is returned in order to check directly if the endpoints managed to change the said file with the intended updates.

Thanks, changed!

renzodgc · 2021-01-18T16:37:22Z

api/tests/app/test_config.py

+# The line below is absolutely necessary. Fixtures are passed as arguments to test functions. That is why IDE could
+# not recognized them.


Suggested change

# The line below is absolutely necessary. Fixtures are passed as arguments to test functions. That is why IDE could

# not recognized them.

# The line below is absolutely necessary. Fixtures are passed as arguments to test functions.

# This is why the IDE can't recognize them.

renzodgc · 2021-01-18T16:40:03Z

api/tests/app/test_config.py

+    # It is weird that this change does not appear in response.json()
+    # Because if request was successfully, the PUT request will change the flag "has_been_configured"


Should this be a FIXME: comment?

This issue was reported and Pablo has already fixed it. :) The comment will be deleted.

api/tests/app/test_config.py

renzodgc · 2021-01-18T16:56:44Z

api/tests/utils/fixtures_tests.py

+
+from fastapi.testclient import TestClient
+
+# from api.tests.utils.common_variables import default


Should this be deleted?

Yes, deleted!

renzodgc · 2021-01-18T16:57:47Z

api/tests/utils/fixtures_tests.py

+    # Here, to import ProcessorAPI successfully, "Settings" must be previously initialized with a config, that is why
+    # import order matters


Suggested change

# Here, to import ProcessorAPI successfully, "Settings" must be previously initialized with a config, that is why

# import order matters

# Import ProcessorAPI after Settings has been initialized with a config.

pgrill reviewed Dec 22, 2020

View reviewed changes

pgrill approved these changes Dec 28, 2020

View reviewed changes

JFer11 added 4 commits January 14, 2021 14:12

First endpoints tests (Routers: App and Config)

23da089

First endpoints tests (Routers: App and Config) II

919363c

Changes based on comments

6681c8d

First Tests, Refactored

dd4155a

JFer11 force-pushed the tests_api_processor_routers branch from 8aa8e0f to dd4155a Compare January 14, 2021 19:37

pgrill requested a review from renzodgc January 15, 2021 20:48

renzodgc reviewed Jan 18, 2021

View reviewed changes

First endpoints tests (Routers: App and Config) III

a67a7b5

renzodgc approved these changes Jan 22, 2021

View reviewed changes

renzodgc merged commit 8a94648 into galliot-us:master Jan 25, 2021

renzodgc deleted the tests_api_processor_routers branch January 25, 2021 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests api processor routers #105

Tests api processor routers #105

JFer11 commented Dec 21, 2020

pgrill Dec 22, 2020

JFer11 Dec 23, 2020 •

edited

Loading

pgrill Dec 22, 2020

JFer11 Dec 23, 2020

pgrill Dec 22, 2020

JFer11 Dec 23, 2020

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

renzodgc Jan 18, 2021

JFer11 Jan 21, 2021

		@@ -0,0 +1,10 @@
		###How tests were built

		To further improve the tests, I made this file to easily understand how they worked.

	To further improve the tests, I made this file to easily understand how they worked.
	This file aims to clarify how the unitary test work.


		To further improve the tests, I made this file to easily understand how they worked.

		The main thing to know is to understand what role fixtures play, especially Config_rollback.


		The main thing to know is to understand what role fixtures play, especially Config_rollback.

		Config_rollback fixture does the following:

	Config_rollback fixture does the following:
	The `Config_rollback` fixture does the following:

	1. setUp: Initialize the app with a different config file (the one with template in the name).
	1. `setUp`: Initializes the app with a different config file (given from the name of an actual config file).

	2. Returns the client to make the request and also returns the root of the config file. That root is also returned in order to go directly to that file and check if the changes made from our endpoints were valid.
	2. Returns the client to make the request and also the root of the config file. The latter is returned in order to check directly if the endpoints managed to change the said file with the intended updates.

		# The line below is absolutely necessary. Fixtures are passed as arguments to test functions. That is why IDE could
		# not recognized them.

		# It is weird that this change does not appear in response.json()
		# Because if request was successfully, the PUT request will change the flag "has_been_configured"


		from fastapi.testclient import TestClient

		# from api.tests.utils.common_variables import default

		# Here, to import ProcessorAPI successfully, "Settings" must be previously initialized with a config, that is why
		# import order matters

	# Here, to import ProcessorAPI successfully, "Settings" must be previously initialized with a config, that is why
	# import order matters
	# Import ProcessorAPI after Settings has been initialized with a config.

Tests api processor routers #105

Tests api processor routers #105

Conversation

JFer11 commented Dec 21, 2020

Choose a reason for hiding this comment

JFer11 Dec 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JFer11 Dec 23, 2020 •

edited

Loading