Unicode leftovers from convertBooleans()

[bastjan]

the replace regex from the method convertBooleans() (\s(\w+)='\u0093true') only finds attributes without dashes in it, so "test='true'" works, but "data-test='true'" does not. marked true/false don't get replaced and confuse some programmers because of the invisible unicode signs.

Possible Solution:
Replace regex so it accepts word characters and dashes:

\s([\w-]+)='\u0093true'

other possible solution:

strip all \u0093 before outputing them

[netzpirat]

Thanks for reporting. The first solution sounds simple, can you please make a pull request?

[bastjan]

I'll do a pull request. I'm not sure if removing html5 data-* attributes is expected when they are false/true thou.

[netzpirat]

You're right, I think we should not touch the data attributes.

[bastjan]

I'll try the second solution. it is not this hard either and should not break anything.

[bastjan]

sticked with the first solution, now

- boolTrue = true
%input{data-test: boolTrue}

and

%input{data-test: true}

work the same way

[netzpirat]

Yes, makes absolutely sense to keep it consistent.