Fix template names when walkdir returns absolute paths. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,6 +186,10 @@ exports.run = -> | |||
|
|
|||
| # Loop through all Haml files and compile them | |||
| for filename in walkdir.sync baseDir | |||
| # walkdir sometimes returns absolute paths | |||
| if filename.substring(0, 1) is '/' | |||
There was a problem hiding this comment.
filename = path.relative baseDir, filename if filename[..0] is '/'Seems a bit more coffee-ish. Just a minor nitpick though.
|
Looks good to me. Thanks for the contribution. Would you mind adding a test case to the spec that proves the bug existed (and that this patch fixes it) before we merge this in? |
|
Thanks for the PR and @mehcode for handling this. I'm on holiday and won't be able to do any work before the first week of August. I'm fine merging this without tests, because we do not have a single unit test yet at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the following command in Ubuntu 12.04.2 with node 0.10.12
haml-coffee -i . -o ../some/path/templates.jsThe template names contained absolute paths instead of relative paths. I traced that to walkdir returning absolute paths when called as
walkdir.sync('.'). This change works around thewalkdiroddness and gets the correct template names.