Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

' doesn't work in IE8 #30

Closed
kalasjocke opened this issue Jul 10, 2012 · 2 comments
Closed

' doesn't work in IE8 #30

kalasjocke opened this issue Jul 10, 2012 · 2 comments

Comments

@kalasjocke
Copy link
Collaborator

Hi,

I just discovered that & apos; doesn't work in IE8 and the solution is to use & #39; according to this bug [1]. I tracked down where the replacement happen in the code, but I didn't find any tests to verify this behavior, so I created this issue instead.

Do you think it's a good idea to change the replacement from & apos; to & #39;?

Thanks for a great library.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=661815

@kalasjocke
Copy link
Collaborator Author

Alright, so I managed to come up with a escaped solution that takes the & apos; into account, but It feels a but unreadable.

587         "code following '=' when escape_haml is set to true" : {           
588             "haml" : "= \"<'\\\"&>\"",                                     
589             "html" : "&lt;&apos;&quot;&amp;&gt;",                          
590             "config" : {                                                   
591                 "escape_html" : "true"                                     
592             }                                                              
593         }, 

What do you think?

@netzpirat
Copy link
Owner

Sorry for being late to the party, I enjoy my holidays and since the connection fees are rather high, I try to limit my Internet usage.

I'm fine with changing the apostrophe entity, since there are no downsides for other browsers, but Haml-Coffee will have better compatibility with ancient browsers.

When I took over the Haml Coffee development, a lot of code already exists but no test, so I decided to only have integration tests since my time to spent was limited. The template helpers have some tests within Haml Coffee Assets, but I didn't port them to Haml Coffee for now. Your test snippet looks fine, I'd definitely merge a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants