Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology aware scale-from-zero running of NSEs in response to NSC demand: Add networkservice chain element that notifies if there no active connections #907

Closed
denis-tingaikin opened this issue May 5, 2021 · 0 comments · Fixed by #908
Assignees
Labels
enhancement New feature or request Planning The issue that related to current SOW

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented May 5, 2021

Overview

We need to shut down all supplied nse that had scaled from zero. For this, we need to add a chain element that can notify about no connection during some period.

Implementation details

  1. Add new networkservice https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/networkservice.pb.go#L251-L254 Server element into networkservice/common pkg
  2. The element should expect two parameters: timeout, notifier. Note: these parameters have default values. For timeout it is 10m. For notifier it can be exit 0.
  3. Implement count logic for requests and closes.
  4. If there no request and no active connections during some peridod or no request from start then call notifier.
  5. Add unit tests to cover.

References

#892

@denis-tingaikin denis-tingaikin added enhancement New feature or request Planning The issue that related to current SOW labels May 5, 2021
@d-uzlov d-uzlov mentioned this issue May 5, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Planning The issue that related to current SOW
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants