Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect margin on Alerts #372

Closed
2 tasks done
lem-onade opened this issue Jul 22, 2021 · 0 comments · Fixed by #431
Closed
2 tasks done

Incorrect margin on Alerts #372

lem-onade opened this issue Jul 22, 2021 · 0 comments · Fixed by #431
Assignees
@arnevandoorslaer
Labels
bug Something isn't working

Comments

@lem-onade
Copy link
Collaborator

lem-onade commented Jul 22, 2021 •
edited by arnevandoorslaer
Loading

As seen in #368

ErrorMessage

Perhaps other pages as well.

  • Add margin-bottom
  • In some places, .content parent div might need display:flex; flex-direcction: column for margin to work

I suggest adding a hardcoded alert to the app machine's context for testing
@lem-onade lem-onade added the bug Something isn't working label Jul 22, 2021
@arnevandoorslaer arnevandoorslaer linked a pull request Aug 18, 2021 that will close this issue
feat: incorrect margin on alerts #431
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnevandoorslaer arnevandoorslaer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: incorrect margin on alerts netwerk-digitaal-erfgoed/solid-crs
2 participants
@lem-onade @arnevandoorslaer