Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show sources of licenses #439

Merged
merged 4 commits into from
Aug 24, 2021
Merged

feat: show sources of licenses #439

merged 4 commits into from
Aug 24, 2021

Conversation

arnevandoorslaer
Copy link
Collaborator

No description provided.

@arnevandoorslaer arnevandoorslaer self-assigned this Aug 23, 2021
@arnevandoorslaer arnevandoorslaer linked an issue Aug 23, 2021 that may be closed by this pull request
Object description form: show sources of licenses #414
Closed
1 task
@arnevandoorslaer
Copy link
Collaborator Author

image
image

@lem-onade
Copy link
Collaborator

@sdevalk See screenshots above, is this what you had in mind?

@sdevalk
Copy link
Collaborator

sdevalk commented Aug 23, 2021

@lem-onade Perfect!

Detail: would it be possible to use a regular character casing, to make the labels less screamy? E.g. RightsStatements.org: Auteursrechtelijk beschermd?

@lem-onade
Copy link
Collaborator

@lem-onade Perfect!

Detail: would it be possible to use a regular character casing, to make the labels less screamy? E.g. RightsStatements.org: Auteursrechtelijk beschermd?

Sure, but since we're taking a part of that license's URI as prefix, capitalizing the S in RightStatements.org might be a hassle. Is Rightsstatements.org: Auteursrechtelijk beschermd fine as well?

@sdevalk
Copy link
Collaborator

sdevalk commented Aug 23, 2021

@lem-onade Perfect!
Detail: would it be possible to use a regular character casing, to make the labels less screamy? E.g. RightsStatements.org: Auteursrechtelijk beschermd?

Sure, but since we're taking a part of that license's URI as prefix, capitalizing the S in RightStatements.org might be a hassle. Is Rightsstatements.org: Auteursrechtelijk beschermd fine as well?

Excellent!

@arnevandoorslaer arnevandoorslaer marked this pull request as ready for review August 24, 2021 09:21
@lem-onade lem-onade merged commit 590a331 into develop Aug 24, 2021
@lem-onade lem-onade deleted the feat/show-sources-of-licenses branch August 24, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lem-onade lem-onade lem-onade approved these changes

Assignees

@arnevandoorslaer arnevandoorslaer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object description form: show sources of licenses
3 participants
@arnevandoorslaer @lem-onade @sdevalk