Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed VS Code adding a backslash to the * in the path #102

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Mar 3, 2023

Description

For some reason VS Code added a \ before the * in the path. Looks like it was due to my default file format being markdown.

Side note, but I have an issue to test the deploys of each template which would have caught this. I will prioritize it. See #90.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

  1. Ensure the Netlify CLI is installed and up to date.
  2. There are two test scenarios:
    • Create a Remix app using TypeScript for Netlify Functions
    • Create a Remix app using JavaScript for Netlify Functions
  3. For each scenario, it always starts by running the following from the root folder in a shell.
npx create-remix --template ./
  1. The CLI will prompt for a location for the project.
❯ npx create-remix --template ./
? Where would you like to create your app? (./my-remix-app)

Ensure that the location is outside of the Netlify Remix template folder, e.g. ../my-remix-app

  1. The Remix CLI will prompt you to choose TypeScript or JavaScript. Choose accordingly for the given test scenarios mentioned above.
? TypeScript or JavaScript? (Use arrow keys)
❯ TypeScript 
  JavaScript
  1. The Remix CLI will prompt you to install packages, press the ENTER to accept the default answer of Yes
? Do you want me to run `npm install`? (Y/n)

The npm packages will install.

  1. Some files will be manipulated if JavaScript is selected. The Remix CLI will output something similar to this.
⠹ Creating your app…⠋ Migrating template to JavaScript…Processing 3 files... 
Spawning 3 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
⠴ Migrating template to JavaScript… SKIP /Users/nicktaylor/dev/remix-tests/edgy-ts/globals.d.ts
⠦ Migrating template to JavaScript… OKK /Users/nicktaylor/dev/remix-tests/edgy-ts/remix.init/root.tsx
 OKK /Users/nicktaylor/dev/remix-tests/edgy-ts/remix.init/entry.server.tsx
All done. 
Results: 
0 errors
0 unmodified
1 skipped
2 ok
Time elapsed: 0.428seconds
  1. The Remix CLI extended with our questions will prompt to create the app with Netlify Functions or Netlify Edge Functions.
💿 Running remix.init script
? Run your Remix site with: (Use arrow keys)
❯ Netlify Functions - Choose this for stable support for production sites 
  Netlify Edge Functions (beta) - Try this for improved performance on non-critical sites

10 Select Netlify Functions by pressing the ENTER key.
10. Change to the directory of the project you just created, e.g. ../my-remix-app
13. The netlify.toml for the project should be the same as the one in this PR.
14. Run npm install

Test remix dev

  1. Run
npm run dev
  1. The Remix dev server starts
➜ npm run dev

> dev
> remix dev

Remix App Server started at http://localhost:3000 (http://192.168.86.78:3000)
This is an example of how to set caching headers for a route, feel free to change the value of 60 seconds or remove the header
GET / 200 - - 38.115 ms
This is an example of how to set caching headers for a route, feel free to change the value of 60 seconds or remove the header
GET / 200 - - 2.539 ms
  1. Navigate to http//:localhost:3000 to see the page load.

CleanShot 2023-02-27 at 16 52 03

  1. Make some changes to the text in app/routes/index.tsx (or jsx)
  2. The page reloads with the changes.

Test with Netlify CLI ntl dev

  1. Run ntl dev
  2. The Remix dev server starts up.
  3. Navigate to https://localhost:8888 and the page loads.
  4. Make some changes to the text in app/routes/index.tsx (or jsx)
  5. The page reloads with the changes.

image
For us to review and ship your PR efficiently, please perform the following steps:

Test with Netlify CLI ntl serve

  1. Run npm run start
  2. ntl serve runs (not the Remix dev server)
  3. The _custom_redirects file gets copied to public/_redirects
  4. Navigate to https://localhost:8888 and the page loads.

image

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we
    can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style
    guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@nickytonline nickytonline self-assigned this Mar 3, 2023
@nickytonline nickytonline requested a review from a team March 3, 2023 03:32
@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for remix-edge-on ready!

Name Link
🔨 Latest commit 08b5d65
🔍 Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/64016a4c4589060008210bae
😎 Deploy Preview https://deploy-preview-102--remix-edge-on.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 3, 2023
@kodiakhq kodiakhq bot merged commit dc4b38c into main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants