Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Tests for the 4 types of apps that can be created #90

Closed
nickytonline opened this issue Feb 24, 2023 · 2 comments
Closed

Add E2E Tests for the 4 types of apps that can be created #90

nickytonline opened this issue Feb 24, 2023 · 2 comments

Comments

@nickytonline
Copy link
Contributor

nickytonline commented Feb 24, 2023

Currently the deploy preview makes no sense once #83 is merged. The new template supports selecting:

  • Remix with Netlify Functions (JavaScript or TypeScript)
  • Remix with Netlify Edge Functions (JavaScript or TypeScript)

The Remix CLI and remix.init script we have rely on inquirer.js. To be able to generate the templates in CI, we'd need to mock inquirer.js.

Once we are able to generate the apps for all the scenarios above, we could run a local version in the GH action that we could used for E2E tests.

So pre-steps instead of waiting for a deploy preview would be:

  1. generate new app for scenario x
  2. Run ntl build --offline.
  3. Run ntl serve
  4. Run E2E tests based off of http://localhost:8888

Having this in place would have prevented #90.

@nickytonline
Copy link
Contributor Author

It would also be good to add an image that validates that exluded_patterns: ["_assets/*"] doesn't break. Note, it currently works well.

@nickytonline
Copy link
Contributor Author

These should generate sites nightly as things move fast. See #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants