Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented Remix server adapter and runtime for Netlify #16
feat: implemented Remix server adapter and runtime for Netlify #16
Changes from 35 commits
e141d98
8e56897
79bb70d
379fcf9
c5b3b36
2faaffa
4bc07ea
569bc20
959a30b
a58e06e
853ac97
cb6cdee
21d9bf8
8b3cd57
84fdc49
aaaff6f
7b03c6c
1007d4d
a0038db
f570e9c
9974faa
7b0970a
360b94b
6f258da
e0b4e65
3b2e8cc
e9927b0
4333b20
f788018
c443950
0c15673
ce64771
af313d0
67fe4d4
cfb4cbd
8676091
9ce4b79
27c4b51
cd4d261
daafe3f
f616d4f
993a262
6ed4e65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind having a peek at this @stephmarie17? It's to the point, but just want to make sure about the wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Clear and to the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new Cypress config. It's what's used now instead of cypress.json, ci.json etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the Cypress format config for the Remix Edge demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascorbic, all the files in
e9927b0
(#16) is the best setup for a deploy I could get going. Also, the change in 4333b20#diff-07374dfaf56a1e11c7f1b9216123fb94be5458e2ca11f70f170fdc9a283aee72R9.It's a monorepo where the edge demo site requires the
@netlify/remix-edge-adapter
and@netlify/remix-runtime
to be built first so that the edge demo site can build. I tried thecd
trick with a base URL in the root netlify.toml, but couldn't get that working as the base url ofpackages/edge-demo-site
wasn't installing all the packages for the monorepo.That was also why I had issues with
if-env
andhusky
not being found on git push deploys. Definitely open to suggestions as I imagine at some point soon, the Netlify Functions demo site will be in here as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than the toml you could set these in the UI, which would let you use different commands and roots for each site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good call about using different commands. The root would stay the same though as I need the monorepo to install everything. I'll make this change once we bring the Netlify Functions adapter into the project.