Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress always fails on main waiting on deploy preview #52

Closed
nickytonline opened this issue Feb 21, 2023 · 1 comment
Closed

Cypress always fails on main waiting on deploy preview #52

nickytonline opened this issue Feb 21, 2023 · 1 comment

Comments

@nickytonline
Copy link
Contributor

When there are pull requests (PR), the deploy preview for a pull request deploys in a timely manner and the Cypress E2E tests pass in our GitHub action. For some reason, once a PR is merged, the deploy preview takes longer than expected and the Cypress tests fail because the deploy preview is not ready in a timely manner.

I haven't had time to look into this yet, but it'd be good to get this sorted. Here is an example of a failure:

This PR's deploy preview and Cypress tests pass fine #49

However, when merged, here is the result https://github.com/netlify/remix-compute/actions/runs/4228571747/jobs/7344140750#step:22:133

Prepare all required actions
Getting action download info
Download action repository 'tj-actions/branch-names@v6' (SHA:eee8675bd61ec38bcfbfedd504d8473[2](https://github.com/netlify/remix-compute/actions/runs/4228571747/jobs/7344140750#step:6:2)92ba649e)
Download action repository 'actions/github-script@v6' (SHA:98814c5[3](https://github.com/netlify/remix-compute/actions/runs/4228571747/jobs/7344140750#step:6:3)be79b1d30f795b907e553d86793[4](https://github.com/netlify/remix-compute/actions/runs/4228571747/jobs/7344140750#step:6:4)[5](https://github.com/netlify/remix-compute/actions/runs/4228571747/jobs/7344140750#step:6:5)975)
Run ./.github/actions/wait-for-netlify-deploy
Run tj-actions/branch-names@v6
Run # "Set branch names..."
Run # "Set the current branch name..."
Run # "Set the default branch name..."
Run # "Set the tag name..."
Run actions/github-script@v6
Waiting for Netlify deploy.
  Check the queue: https://app.netlify.com/sites/remix-edge/deploys
Error: Timeout exceeded
@MarcL MarcL changed the title Cypress always fails on main wiating on deploy preview Cypress always fails on main waiting on deploy preview Feb 22, 2023
@serhalp
Copy link
Contributor

serhalp commented May 14, 2024

Superseded/fixed by #316

@serhalp serhalp closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants