Fix list items crashing for first fields other than strings. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit 4d3f05b |
|
Deploy preview for cms-demo ready! Built with commit 4d3f05b |
erquhart
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
If the first field in a list widget didn't return a string (or React component), the CMS would crash. This was because the CMS was trying to render the value of the first widget when a list item was collapsed, as explained in the related issue.
Fixes #1113.
- Test plan
Manually tested with date widget.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)