Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export builder types correctly #371

Merged
merged 1 commit into from
Jan 5, 2023
Merged

feat: export builder types correctly #371

merged 1 commit into from
Jan 5, 2023

Conversation

danez
Copy link
Contributor

@danez danez commented Jan 5, 2023

This simply adds BuilderHandler and BuilderResponse types to the main exports.

@danez danez requested review from charliegroll and a team January 5, 2023 12:26
@danez danez self-assigned this Jan 5, 2023
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 5, 2023
eduardoboucas
eduardoboucas approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this to be a fix: and not a feat:?

@danez danez changed the title fix: export builder types correctly feat: export builder types correctly Jan 5, 2023
@danez danez merged commit 24fc838 into main Jan 5, 2023
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 5, 2023
@danez danez deleted the function-response branch January 5, 2023 13:55
@token-generator-app token-generator-app bot mentioned this pull request Jan 5, 2023
Merged
danez pushed a commit that referenced this pull request Jan 5, 2023
@token-generator-app
chore(main): release 1.4.0 (#372)
7aace56 
🤖 I have created a release *beep* *boop*
---


## [1.4.0](v1.3.0...v1.4.0)
(2023-01-05)


### Features

* export builder types correctly
([#371](#371))
([24fc838](24fc838))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

@charliegroll charliegroll Awaiting requested review from charliegroll

Assignees

@danez danez

Labels
type: bug code to address defects in shipped code type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danez @eduardoboucas