-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return generated manifest object #48
Conversation
I would argue that actually reading the file from its expected location at deploy time would be part of the diagnostic. Any reason you prefer to expose it programmatically and skip that step? |
Hmmm, I figured the contents of the manifest were the important part, rather than the loading of the manifest file itself. So figured it would be cleaner to just return it, rather than reload the contents from the file again. I wasn't 100% sure on that though, so happy to close this and just reload it in the builder |
No objections from me! I just wanted to offer an alternative option in case you hadn't considered it, as it could avoid making changes to Edge Bundler. |
…tlify/edge-bundler into feat/return-generated-manifest-object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! ✨
* feat: return generated manifest object * chore: updated options params
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)