-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for config
export
#133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Sep 21, 2022
eduardoboucas
force-pushed
the
feat/config
branch
from
September 28, 2022 16:10
47ad3a7
to
50b501a
Compare
eduardoboucas
commented
Sep 30, 2022
@@ -124,8 +117,7 @@ const bundle = async ( | |||
// if any. | |||
const importMap = new ImportMap(importMaps) | |||
const functions = await findFunctions(sourceDirectories) | |||
|
|||
const bundleOps = createBundleOps({ | |||
const functionBundle = await createBundle({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're no longer creating multiple bundles, so I've simplified this a bit.
jackiewmacharia
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* feat: add support for `config` export * refactor: add collector file * refactor: use file URL * feat: add exit codes * fix: pass logger * chore: setup Deno in integration workflow * refactor: move config extractor to separate file * feat: print stdout * refactor: run config after bundling * chore: add comments * chore: improve tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for in-source configuration in edge functions. Rather than forcing people to have a
netlify.toml
where they declare the paths for each edge function as well as other configuration parameters, we allow them to declare the same parameters from within aconfig
export in the function's entry point file.It works by looking for a
config
export, which should be a function. When one is found, Edge Bundler will invoke that function at build time and use its output (which must be serialisable to JSON) as the input for the configuration object.Here's an example:
netlify/edge-functions/hello.ts
NOTE: Edge functions declared using this format will run after any edge functions declared in the TOML, and they will run in alphabetical order (within the group of functions defined using this method). So if you're chaining multiple edge functions and you want to control the order in which they run, the TOML declaration method is preferred.