feat: export metadata object in local stage 2
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
mraerino
reviewed
Sep 15, 2022
test/node/stage_2.ts
Outdated
| return | ||
| } | ||
|
|
||
| const { stdout, stderr } = await execa('node', [stage2Path]) |
There was a problem hiding this comment.
my understanding would be that the code you are generating runs in deno? why are you executing node here?
There was a problem hiding this comment.
This code runs in Node as part of local development, called by the CLI.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hang on, I'm holding this wrong! This is called from Node but then actually runs in Deno. 🤯
Let me change this.
There was a problem hiding this comment.
Done in 4fcd2c1. Thanks!
mraerino
approved these changes
Sep 15, 2022
This was referenced Sep 16, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…#126) * feat: add `metadata` object to local stage 2 * chore: add comment * chore: use file URL in test * chore: adjust test for Node <14 * chore: run stage 2 in Deno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #122 but for the stage 2 file used in local development.