Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowing behavior breaks when request URL has query params #939

Closed
RaeesBhatti opened this issue Jun 4, 2020 · 0 comments · Fixed by #940
Closed

Shadowing behavior breaks when request URL has query params #939

RaeesBhatti opened this issue Jun 4, 2020 · 0 comments · Fixed by #940
Assignees
Labels
type: bug code to address defects in shipped code

Comments

@RaeesBhatti
Copy link
Contributor

- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
If request URL is /something?ping=pong, netlify dev will look for variants of files name something?ping=pong.

- If the current behavior is a bug, please provide the steps to reproduce.

  • Run netlify dev
  • Have a file at /something.html
  • Visit /something?ping=pong

- What is the expected behavior?

netlify dev ignores query string params when looking for shadowing files

- Local Environment Information

────────────────────┐
 Environment Info   │
────────────────────┘

  System:
    OS: macOS 10.15.5
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 12.18.0 - ~/.n/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.n/bin/npm
  Browsers:
    Chrome: 83.0.4103.97
    Firefox: 76.0
    Safari: 13.1.1
  npmGlobalPackages:
    netlify-cli: 2.53.0

netlify-cli/2.53.0 darwin-x64 node-v12.18.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant