Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(command-deploy): support passing a branch when triggering a deploy #1572

Open
erezrokah opened this issue Nov 19, 2020 · 3 comments
Open
Labels
area: command: deploy type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Related to #275 (comment)

netlify deploy --trigger doesn't support passing an --alias.

Describe the solution you'd like

Ability to trigger a deploy for a specific existing branch/PR.

Describe alternatives you've considered

N/A

Additional context

See #275 (comment)

This will require the API to support it.

Can you submit a pull request?

Yes

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 19, 2020
@erezrokah erezrokah changed the title Feature(command-deploy): support passing a branch when calling deploy with --trigger Feature(command-deploy): support passing a branch when triggering a deploy Nov 19, 2020
@matyasf
Copy link

matyasf commented Mar 12, 2021

Any update on this feature? Can we expect it to be implemented?

@erezrokah
Copy link
Contributor Author

Hi @matyasf, no timeline for this yet.
The CLI uses https://open-api.netlify.com/#operation/createSiteBuild to endpoint to trigger a deploy which currently doesn't support passing a branch.

We'll first need to add this to our API.

@csvn
Copy link

csvn commented Dec 8, 2021

This feature would be really nice to get branch subdomains working out of the box when using Netlify DNS. We are running netlify deploy --alias=$CI_COMMIT_REF_SLUG for branches via Gitlab CI to get review apps/URL's for merge requests.

We'll first need to add this to our API.

Are there any plans to update this API to allow this, or this just in the backlog? I'm wondering in case we want to replace Netlify DNS with our own logic to make this work or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: deploy type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

3 participants