Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

feat: Update Emacs to version 28.1 #842

Closed
wants to merge 1 commit into from
Closed

feat: Update Emacs to version 28.1 #842

wants to merge 1 commit into from

Conversation

kaushalmodi
Copy link

@kaushalmodi kaushalmodi commented Oct 7, 2022 •
edited
Loading

Fixes #782.

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #782.

This PR is necessary because I have started facing Emacs package build dependency issues when building some sites that rely on Emacs. The current default Emacs version 26.3 is more than 3 years old. This PR bumps up the Emacs version to 28.1 that got released in April 2022.

image

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update the included software doc (if you updated included software) 📄
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

image

@kaushalmodi kaushalmodi requested a review from a team October 7, 2022 15:57
@kaushalmodi
Copy link
Author

I'll need help with this PR. The build error says:

54.18 E: Unable to locate package emacs28-nox

But from https://github.com/kelleyk/ppa-emacs, I read that

You'll need to pick one of these types of packages to install.

  • emacs28: With support for X11 via GTK3. You may also want to consider trying emacs28-nativecomp.
  • emacs28-nox: Without support for X11.
  • emacs28-nativecomp: Same configuration as emacs28 but with native compilation. These packages are available for 22.04 LTS ("focal") and later.

@kaushalmodi kaushalmodi force-pushed the update-emacs-to-v28 branch 2 times, most recently from 5364097 to 916d38b Compare October 7, 2022 16:05
@kaushalmodi kaushalmodi changed the title feat: Update Emacs to version 28 feat: Update Emacs to version 28.1 Oct 7, 2022
@kaushalmodi
Copy link
Author

@Benaiah Can you please review this? I had to re-add ppa:kelleyk/emacs that was removed in 26189bc so that emacs28-nox can be installed.

@kaushalmodi
Copy link
Author

The CI is on hold. How to proceed?

image

@kitop
Copy link
Contributor

kitop commented Oct 7, 2022

@kaushalmodi Currenlty we're a bit limited in bandwidth to review, merge, and release contributions.

You can install newer versions of emacs via Hombrew at the moment. See https://answers.netlify.com/t/now-in-experimental-alpha-homebrew-access-in-the-build-image/26074 for details.
Keep in mind it's still in alpha, but it should unblock your use case.

@kaushalmodi
Copy link
Author

@kitop If you don't mind, can you please tag this PR hacktoberfest-accepted ?

@kitop
Copy link
Contributor

kitop commented Dec 6, 2022

I'm going to close this since we don't have the bandwidth to support it and seems to be an edge case that can be worked around with Homebrew

@kitop kitop closed this Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the default Emacs version to 28.1
2 participants
@kaushalmodi @kitop