Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Caching no longer works #318

Closed
yacoob opened this issue May 29, 2019 · 3 comments
Closed

Caching no longer works #318

yacoob opened this issue May 29, 2019 · 3 comments

Comments

@yacoob
Copy link
Contributor

yacoob commented May 29, 2019

I'm probably missing something here :)

I took a stab at adding Rust support to the build image. Things seem to be working fine, except my cache (as in, $NETLIFY_CACHE_DIR) is not getting populated. It looks like since 23b55c2 cache_artifacts is not getting called at all during run-build.sh. As a result, no caching is performed and every build starts from scratch. Adding cache_artifacts as a last step before exiting from run-build.sh results in cache getting populated.

Now, the confusing bit is the fact that my actual deploys on netlify say:

10:44:16 PM: build-image tag: v3.3.2

but then continue to say:

10:44:47 PM: Caching artifacts

3.3.2 should have caching broken. I'm obviously missing something here, right? :D

Thanks!

@yacoob
Copy link
Contributor Author

yacoob commented May 30, 2019

For reference: this is what I arrived at:
https://github.com/netlify/build-image/compare/xenial...yacoob:rust?expand=1

The caching wouldn't work in local tests, until I've added that explicit call to cache_artifacts.

@XhmikosR
Copy link

This is definitely a regression in the Xenial image. Can we get a fix please?

@XhmikosR
Copy link

/CC @bcomnes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants