-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): add the MainPageTopBar component and hidden title bar of Electron #1468
Merged
BlackHole1
merged 18 commits into
netless-io:main
from
Cheerego7:feat-add-main-page-top-bar-component
Apr 21, 2022
Merged
feat(project): add the MainPageTopBar component and hidden title bar of Electron #1468
BlackHole1
merged 18 commits into
netless-io:main
from
Cheerego7:feat-add-main-page-top-bar-component
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cheerego7
commented
Apr 8, 2022
•
edited
Loading
edited
- feat(flat-components): add the MainPageTopBar, WindowsSystemBtn component
- feat(renderer-app): hidden the titleBarStyle of Electron
- feat(renderer-app): add new FlatIcon and remove unused SVG resource
- refactor(renderder-app): change layout of classroom page and MainPageLayout components
hyrious
previously approved these changes
Apr 8, 2022
crimx
previously approved these changes
Apr 9, 2022
Cheerego7
force-pushed
the
feat-add-main-page-top-bar-component
branch
4 times, most recently
from
April 18, 2022 03:34
c72bbab
to
5f10747
Compare
Cheerego7
force-pushed
the
feat-add-main-page-top-bar-component
branch
4 times, most recently
from
April 20, 2022 05:23
f4f42c1
to
b66307d
Compare
Cheerego7
force-pushed
the
feat-add-main-page-top-bar-component
branch
from
April 20, 2022 07:20
b66307d
to
dae972e
Compare
…s to TopBar components
BlackHole1
requested changes
Apr 21, 2022
desktop/main-app/src/window-manager/window-portal/window-preview-file.ts
Outdated
Show resolved
Hide resolved
desktop/main-app/src/window-manager/window-portal/window-share-screen-tip.ts
Outdated
Show resolved
Hide resolved
LitoMore
reviewed
Apr 21, 2022
packages/flat-components/src/components/ClassroomPage/TopBar/style.less
Outdated
Show resolved
Hide resolved
packages/flat-components/src/components/MainPageLayout/MainPageNav/style.less
Outdated
Show resolved
Hide resolved
BlackHole1
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.