[NAE-2052] Integrate ticket view with menu items #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement resolving of auto-select views in double-drawer
- abstract loading and navigation in double drawer menu - implement default view opening in double drawer menu
- update tests according to changes
- add all nessesery public view components into engine default components
- fix tests
- fix tests
- fix tests
- add single task view and tabbed single task view to default components - add directories
- copy of the files from project
# Conflicts: # projects/netgrif-components-core/src/lib/navigation/navigation-double-drawer/abstract-navigation-double-drawer.ts
- rework component resolving because of backend changes - rename preference_item to menu_item
- update test for default-tab-view.component
- update imports in double-drawer-navigation.service - add event emit in double-drawer-navigation.service
- add ticket view to default components and implement it as tabbed view
- implement handling of ticket view in double-drawer menu
Retoocs
requested review from
camperko,
Kovy95,
SamuelPalaj,
MartinSiran and
mazarijuraj
|
This test error is possibly from the branch I depend on. I will rerun tests as soon as it's fixed there EDIT: it was fixed in the NAE-2041. I pulled the branch and none of the tests fail now |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented handling of new menu item configurations for DefaultTabbedTicketView and DefaultTabbedSingleTaskView
Implements NAE-2052
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
Depends on #261 and #267
How Has Been This Tested?
Manually and with tests
Test Configuration
Checklist: