Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-2033] Welcome dashboard #263

Merged
merged 7 commits into from
Feb 18, 2025
Merged

[NAE-2033] Welcome dashboard #263

merged 7 commits into from
Feb 18, 2025

Conversation

camperko
Copy link
Member

@camperko camperko commented Feb 7, 2025

Description

Implements configurable dashboard component. Component is managed by process dashboard_management and displays dashboard items (dashboard_item process) in tile view.
Configuration available in dashboard:

  • add dashboard item
  • remove dashboard item
  • reorder items
  • changes to toolbar

Configuration for dashboard items:

  • name of item
  • icon of item (material or web icon)
  • font/icon color
  • font weight
  • internal/external item

Implements NAE-2033

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

Depends on #(261)

How Has Been This Tested?

Manually from application

Name Tested on
OS Linux Mint 21
Runtime Node 20.13.1
Dependency Manager npm 10.8.0
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Retoocs and others added 6 commits January 28, 2025 10:03
- implement resolving of auto-select views in double-drawer
- abstract loading and navigation in double drawer menu
- implement default view opening in double drawer menu
- update tests according to changes
- create dashboard component + dashboard example view
# Conflicts:
#	projects/netgrif-components-core/src/lib/navigation/public-api.ts
- loading of dashboard management case
- loading dashboard item cases
- dashboard displaying
@camperko camperko changed the title Nae 2033 [NAE-2033] Úvodný dashboard Feb 7, 2025
@camperko camperko self-assigned this Feb 7, 2025
@camperko camperko added improvement New feature or request new feature labels Feb 7, 2025
@Retoocs Retoocs changed the title [NAE-2033] Úvodný dashboard [NAE-2033] Welcome dashboard Feb 11, 2025

public logout(): void {
this.userService.logout().subscribe(() => {
this.router.navigate(['login']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get this string from nae.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or RedirectService -> resolveLoginPath()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to dashboard_management

}

public profile(): void {
this.router.navigate(['profile']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a property in nae.json to set the url to profile component

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to dashboard_management process

- fix tests
- refactor code by PR comments
- add option to change urls of login and profile in dashboard toolbar
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Coverage on New Code (required ≥ 50%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mazarijuraj mazarijuraj merged commit cec22d5 into release/6.5.0 Feb 18, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants