-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing deprecated python cookbook with poise-python #13
base: master
Are you sure you want to change the base?
Conversation
…lt install package to version 2.5. Moving location of as.conf under the etc/ folder.
@@ -27,7 +27,6 @@ do | |||
done | |||
echo 'collecting extra files' | |||
cp $OPENVPNAS_DIR/etc/as.conf $BACKUP_DIR | |||
cp $OPENVPNAS_DIR/etc/config.json $BACKUP_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason to remove this line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that file is generated during the restore process. Latest openvpn backup/restore docs don't make reference to that file. https://docs.openvpn.net/configuration/migrating-an-access-server-installation/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
*.un~ | ||
|
||
# Bundler | ||
Gemfile.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it's a good idea to gitignore this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked up a boiler place .gitignore file from a different cookbook project. I was simply trying to avoid checking in the .kitchen folder/directory and Berksfile.lock since I don't think those files need to be committed. I can remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind ignoring it, but if we go this way we should remove the file from the repo first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I guess if you remove it, it'll fix travis build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work on getting the build back in working order. I haven't had much time to look into it. Looks like just deleting the .lock file didn't work.
No description provided.