feat: Faster Cursors #118
Merged
feat: Faster Cursors #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE The new cursor intentonally disallows storing cursors inside cursor to warn against difficuilt to track situations that can lead to infinite loops. Consequently the intenal redux store now keeps a vanilla immutable structure as `state` rather than a cursor. This shouldn't cause trouble except in redux middleware where the state is accessed directly.
This reverts commit c7e6e8b.
Pull Request Test Coverage Report for Build 355
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests resolves #115.
The
immutable/contrib/cursorimplementation has been refined so that each cursor holds a pointer to the current data object in addition to root and keyPath. This makesgetInand especiallygetlookups 10x faster than before. Asrendermethods usually are quite heavy ingetcalls, this should improve rendering significantly.BREAKING CHANGE
The new cursor intentonally disallows storing cursors inside cursor
to warn against difficuilt to track situations that can lead to infinite loops.
Consequently the intenal redux store now keeps a vanilla immutable
structure as
staterather than a cursor. This shouldn't causetrouble except in redux middleware where the state is accessed
directly.
05b323a