Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugin configuration further improvements #34

Merged
merged 19 commits into from
Sep 26, 2024
Merged

feat: plugin configuration further improvements #34

merged 19 commits into from
Sep 26, 2024

Conversation

mfiedorowicz
Copy link
Member

  • clear diode permissions (migration)
  • add default settings with usernames and diode target (placeholder)
  • allow plugin configuration with PLUGINS_CONFIG:
    • diode_target_override, which takes precedence over diode target stored in the settings model (db)
    • diode_to_netbox_username, netbox_to_diode_username, diode_username to customise diode related usernames
  • rename legacy users to new usernames (using new default or custom ones)

@mfiedorowicz
fix: clear diode permissions
d2b5964 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: allow configuration of diode usernames via PLUGINS_CONFIG
7d6f06e 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: update settings with diode users details
4fbaeb7 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: update ingestion logs view
ebd0567 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
update settings copy for env vars
1af22d0 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
create users using usernames provided with plugin config
60b61af 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
python fmt
6a539cc 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
update migration for creating setting using diode target from plugin …
21230c7 
…config

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
use diode_target_override from plugin config or from database
6707935 
block modifying diode target via GUI if diode_target_override is present

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
migration to rename legacy users
becb14f 
new usernames obtained from plugin config (either default ones or PLUGINS_CONFIG)

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix 0001_initial migration
6bb7e3a 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up 0002_setting migration
61a7ffa 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
adjust unit tests to plugin config changes
b12dc43 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up forms
d496c57 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
disable PLUGINS_CONFIG for docker by default
aba5449 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1523 1507 99% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/plugin_config.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/init.py 100% 🟢
netbox_diode_plugin/forms.py 100% 🟢
netbox_diode_plugin/tests/test_forms.py 100% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
netbox_diode_plugin/views.py 99% 🟢
TOTAL 100% 🟢

updated for commit: 3e886a9 by action🐍

@mfiedorowicz
update README
6b66a81 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@leoparente leoparente self-requested a review September 25, 2024 20:59
leoparente
leoparente approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfiedorowicz
handle missing diode users
5542b12 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
unit tests for handling missing diode users
02a9c5c 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
rename reconciled to changes in ingestion logs metrics gauges
3e886a9 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz merged commit 855e92f into develop Sep 26, 2024
5 checks passed
@mfiedorowicz mfiedorowicz deleted the plugin-configuration-improvements-part-2 branch September 26, 2024 19:35
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
markdown python released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfiedorowicz @orb-ci @leoparente