Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: settings and ingestion logs views (init) #25

Merged
merged 21 commits into from
Sep 9, 2024
Merged

feat: settings and ingestion logs views (init) #25

merged 21 commits into from
Sep 9, 2024

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Sep 6, 2024 •
edited
Loading

  • views to read and edit settings (diode-reconciler service target to start with), stored in dedicated model
  • SDK client for diode-reconciler service allowing to retrieve ingestion logs
  • view to retrieve and read ingestion logs (disabled by default until we have server side implemented), basic connection with diode-reconciler svc working using SDK
  • unit tests
  • set primary user agent composed with {SDK_NAME SDK_VERSION} {PLUGIN_NAME PLUGIN_VERSION}
Screenshot 2024-09-06 at 16 38 36 Screenshot 2024-09-06 at 16 38 41

@mfiedorowicz
feat: add reconciler svc generated from proto
01ee792 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: reload netbox on *.html changes
006a9fa 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add reconciler sdk client
24964ba 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add settings model, form, serializer and migration
69ee93d 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add settings templates
3feaf3e 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
remove redundant grpc status
2d0dd2d 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add regenerated code for reconciler svc proto
64d3da4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up reconciler client error
90f36a7 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add settings view/edit + dummy ingestion logs view
736fa97 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix typo
da3df27 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
omit proto generated files and migrations from code coverage
debe253 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
omit proto generated files when running ruff checks
39a0c74 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up existing tests
c2a6ab0 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
add tests for API serializers
150cd17 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
add tests for Setting model
eaa1295 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
add tests for reconciler SDK client
8aa4af8 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
add tests for views
dbf17d4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
tidy up
61a1d36 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
add plugin config flag to enable retrieving ingestion logs via plugin…
0a83a7b 
… config (disabled by default)

- enabled for tests
- config flag will removed once integration with reconciler service is working.

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1241 1228 99% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/forms.py 100% 🟢
netbox_diode_plugin/reconciler/init.py 100% 🟢
netbox_diode_plugin/reconciler/sdk/init.py 100% 🟢
netbox_diode_plugin/reconciler/sdk/client.py 100% 🟢
netbox_diode_plugin/reconciler/sdk/exceptions.py 100% 🟢
netbox_diode_plugin/reconciler/sdk/v1/init.py 100% 🟢
netbox_diode_plugin/reconciler/sdk/validate/init.py 100% 🟢
netbox_diode_plugin/tests/test_api_serializers.py 100% 🟢
netbox_diode_plugin/tests/test_models.py 100% 🟢
netbox_diode_plugin/tests/test_reconciler_sdk_client.py 100% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/api/serializers.py 99% 🟢
netbox_diode_plugin/models.py 100% 🟢
netbox_diode_plugin/navigation.py 100% 🟢
netbox_diode_plugin/tests/test_version.py 100% 🟢
netbox_diode_plugin/urls.py 100% 🟢
netbox_diode_plugin/views.py 97% 🟢
TOTAL 99% 🟢

updated for commit: 06c48cc by action🐍

leoparente
leoparente approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice frontend skills! LGTM

@mfiedorowicz mfiedorowicz changed the title feat: add views for settings and ingestion logs (init) feat: settings and ingestion logs views (init) Sep 7, 2024
@mfiedorowicz
switch netbox docker to v4.1-3.0.1
9be4d99 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: set primary user agent for reconciler sdk client
06c48cc 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz merged commit aa00897 into develop Sep 9, 2024
7 checks passed
@mfiedorowicz mfiedorowicz deleted the feat/retrieve-ingestion-logs branch September 9, 2024 08:54
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
dependencies internal python released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfiedorowicz @orb-ci @leoparente