Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOCKS support to proxy settings for Git remote data source #17639

Closed
arthanson opened this issue Sep 27, 2024 · 0 comments · Fixed by #17640
Closed

Add SOCKS support to proxy settings for Git remote data source #17639

arthanson opened this issue Sep 27, 2024 · 0 comments · Fixed by #17640
Assignees
@arthanson
Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@arthanson
Copy link
Collaborator

NetBox version

v4.1.2

Feature type

Data model extension

Proposed functionality

Add socks ('socks5:') support for Git remote data sources.

Currently Dulwich (the git client API library) doesn't support passing in HTTP_PROXIES with 'socks5:', this works fine on other proxy requests like WebHooks.

Use case

This is needed if using a secure SOCKS proxy and accessing a remote Git data source.

Database changes

n/a

External dependencies

Requires the python_socks library if used.
@arthanson arthanson added the type: feature Introduction of new functionality to the application label Sep 27, 2024
@arthanson arthanson self-assigned this Sep 27, 2024
@arthanson arthanson mentioned this issue Sep 27, 2024
Merged
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation complexity: medium Requires a substantial but not unusual amount of effort to implement labels Sep 30, 2024
@jeremystretch jeremystretch changed the title Add socks support to proxy settings for Git remote data source Add SOCKS support to proxy settings for Git remote data source Oct 1, 2024
@jeremystretch jeremystretch mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthanson arthanson

Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for socks connection to Git backend netbox-community/netbox
2 participants
@arthanson @jeremystretch