Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mention for forceCloseConnections feature of NestFactory.create #2840

Closed
micalevisk opened this issue Sep 2, 2023 · 3 comments
Closed

Add mention for forceCloseConnections feature of NestFactory.create #2840

micalevisk opened this issue Sep 2, 2023 · 3 comments

Comments

@micalevisk
Copy link
Member

micalevisk commented Sep 2, 2023 •
edited
Loading

That feature introduced in Nestjs v9.2.0 by this PR: nestjs/nest#10345 isn't mentioned anywhere in the docs site.

Not sure where we can mention about that tho
@github-project-automation github-project-automation bot moved this to 🤔 I'll investigate later in My contributions to NestJS framework 😻 Sep 3, 2023
@kamilmysliwiec
Copy link
Member

Perhaps we should add a new chapter under FAQ category?

@micalevisk
Copy link
Member Author

@tolgap do you have any other suggestion?

@tolgap
Copy link
Contributor

tolgap commented Oct 1, 2023 •
edited
Loading

@tolgap do you have any other suggestion?

I think FAQ would be the right directory. Devs will most likely run into the "hanging of the application" when they use .enableShutdownHooks() in their app. So we could add a chapter about why the app might not restart correctly in watch mode and .enableShutdownHooks() and that they should use forceCloseConnections as well👍

@tolgap tolgap mentioned this issue Oct 1, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tolgap @micalevisk @kamilmysliwiec