-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add msgpack serialization format #68
Comments
That's a great idea actually, I am not opposed to adding that as another format. However, I know nothing about msgpack and I do not use it in my apps. If someone wants to write a patch to add a to_msgpack format here: https://github.com/nesquena/rabl/blob/master/lib/rabl/engine.rb#L51 I would much appreciate it. |
I think I understand the engine well enough to attempt to add to_msgpack. It would mostly be a clone of Engine#to_json and Engine#format_json. Question. How to go about the msg pack dependency? There is a hard dependency, but it wouldn't be so nice for people that don't have it, or want it, installed: I think a soft dependency would work out nicely, but with the following warnings:
Which way would you like me to proceed? |
Soft dependency with a note in the readme about enabling msgpack support. |
Also please add corresponding riot tests if you can (check out existing for inspiration). Thanks, nice to have another format enabled for RABL |
I have merged this in. Thanks! 4462ea8 |
It would be nice to include msgpack as another serialization. It would be a benefit to not have to maintain different rendering processes for json and msgpack in my app.
http://msgpack.org/
The text was updated successfully, but these errors were encountered: