From f2bf7428b37b7322d8b59f67539db145e347d674 Mon Sep 17 00:00:00 2001
From: Tom Wang <tom.wanghaiyi@gmail.com>
Date: Wed, 10 Apr 2024 09:03:23 +0800
Subject: [PATCH] refactor: rewrite shannonToCKB with lumos formatUnit

---
 .../neuron-wallet/src/utils/shannonToCKB.ts   | 20 +++++++------------
 .../neuron-wallet/src/utils/to-csv-row.ts     |  2 +-
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/packages/neuron-wallet/src/utils/shannonToCKB.ts b/packages/neuron-wallet/src/utils/shannonToCKB.ts
index 82c1a01871..8d9ba94c69 100644
--- a/packages/neuron-wallet/src/utils/shannonToCKB.ts
+++ b/packages/neuron-wallet/src/utils/shannonToCKB.ts
@@ -1,18 +1,12 @@
-const DECIMAL = 8
+import { formatUnit, ckbDecimals } from '@ckb-lumos/bi'
 
 const shannonToCKB = (shannon: bigint) => {
-  if (shannon === BigInt(0)) {
-    return `+0.${'0'.repeat(DECIMAL)}`
-  }
-
-  const isNegative = shannon < 0
-  const absStr = isNegative ? `${shannon}`.slice(1) : `${shannon}`
-  if (absStr.length <= DECIMAL) {
-    return `${isNegative ? '-' : '+'}0.${absStr.padStart(DECIMAL, '0')}`
-  }
-  const int = absStr.slice(0, -1 * DECIMAL)
-  const dec = absStr.slice(-1 * DECIMAL)
-  return `${isNegative ? '-' : '+'}${int}.${dec}`
+  return new Intl.NumberFormat('en-US', {
+    useGrouping: false,
+    signDisplay: 'always',
+    minimumFractionDigits: ckbDecimals,
+    maximumFractionDigits: ckbDecimals,
+  }).format(formatUnit(shannon, 'ckb') as any)
 }
 
 export default shannonToCKB
diff --git a/packages/neuron-wallet/src/utils/to-csv-row.ts b/packages/neuron-wallet/src/utils/to-csv-row.ts
index ce3d32e842..9992a4e327 100644
--- a/packages/neuron-wallet/src/utils/to-csv-row.ts
+++ b/packages/neuron-wallet/src/utils/to-csv-row.ts
@@ -41,7 +41,7 @@ const toCSVRow = (
       txType = +tx.sudtInfo.amount <= 0 ? `UDT ${SEND_TYPE}` : `UDT ${RECEIVE_TYPE}`
     }
   } else {
-    amount = shannonToCKB(BigInt(tx.value ?? ''))
+    amount = shannonToCKB(BigInt(tx.value ?? '0'))
     if (tx.nervosDao) {
       txType = `Nervos DAO`
     } else if (['create', 'destroy'].includes(tx.type || '')) {