Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file check and friendly error message #102

Closed
doitian opened this issue Dec 17, 2018 · 1 comment
Closed

Config file check and friendly error message #102

doitian opened this issue Dec 17, 2018 · 1 comment
Labels
p:should-have Priority: important but not necessary for delivery in the current delivery timebox s:available Status: This issue is available for implementation. t:enhancement Type: Feature, refactoring.

Comments

@doitian
Copy link
Member

doitian commented Dec 17, 2018 •
edited
Loading

Before booting the node, check the config file first:
@doitian doitian changed the title When loading the config file, the app should check that all paths and report friendly error messages on missing files When loading the config file, the app should check all paths and report friendly error messages on missing files Dec 17, 2018
@doitian doitian added s:available Status: This issue is available for implementation. m:infrastructure t:enhancement Type: Feature, refactoring. and removed enhancement labels Dec 27, 2018
@doitian doitian changed the title When loading the config file, the app should check all paths and report friendly error messages on missing files Config file check and friendly error message Jan 11, 2019
@doitian doitian added the p:should-have Priority: important but not necessary for delivery in the current delivery timebox label Jan 11, 2019
@doitian
Copy link
Member Author

doitian commented Jan 11, 2019 •
edited
Loading

Here is an example of the error in version v0.4.0. It should report the full JSON path to the missing field.

Failed to setup with config /Users/james/Projects/ckb/ckb/nodes/default.json, cause err: Error("missing field `max_block_cycles`", line: 36, column: 5)

@doitian doitian added the 500 label Apr 14, 2019
@doitian doitian removed the 500 label Apr 29, 2019
@doitian doitian added this to the backlog milestone May 6, 2019
@doitian doitian closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:should-have Priority: important but not necessary for delivery in the current delivery timebox s:available Status: This issue is available for implementation. t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doitian