Skip to content

Commit

Permalink
refactor: remove estimate_fee_rate RPC
Browse files Browse the repository at this point in the history
BREAKING CHANGE: remove estimate_fee_rate API and RPC method
  • Loading branch information
shaojunda committed Jul 21, 2020
1 parent 66bdf1b commit 5fa2b1c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 24 deletions.
6 changes: 0 additions & 6 deletions lib/ckb/api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -327,12 +327,6 @@ def get_banned_addresses
result.map { |addr| Types::BannedAddress.from_h(addr) }
end

# @param expect_confirm_blocks [Integer]
def estimate_fee_rate(expect_confirm_blocks)
result = rpc.estimate_fee_rate(expect_confirm_blocks)
Types::EstimateResult.from_h(result)
end

# @param bytes_limit [String | Integer] integer or hex number
# @param proposals_limit [String | Integer] integer or hex number
# @param max_version [String | Integer] integer or hex number
Expand Down
9 changes: 0 additions & 9 deletions spec/ckb/api_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -311,15 +311,6 @@
expect(result).to all(be_a(Types::BannedAddress))
end

it "estimate fee rate" do
begin
result = api.estimate_fee_rate(4)
expect(result).not_to be_a Types::EstimateResult
rescue Exception => e
expect(e).to be_a CKB::RPCError
end
end

context "miner APIs" do
it "get_block_template" do
result = api.get_block_template
Expand Down
9 changes: 0 additions & 9 deletions spec/ckb/rpc_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,6 @@
expect(result).not_to be nil
end

it "estimate fee rate" do
begin
result = rpc.estimate_fee_rate(4)
expect(result).not_to be nil
rescue Exception => e
expect(e).to be_a CKB::RPCError
end
end

context "miner RPCs" do
it "get_block_template" do
result = rpc.get_block_template
Expand Down

0 comments on commit 5fa2b1c

Please sign in to comment.