Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to copy the args of lock script from the transaction page as the format it displayed? #1787

Closed
yangby-cryptape opened this issue Apr 14, 2024 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@yangby-cryptape
Copy link

yangby-cryptape commented Apr 14, 2024

Description

I want to copy the lock script args and go to another page to search this args, to make sure they are the same args.

But, after the upgrade in last week (maybe two weeks ago, I guess).

When I select the args, I could NOT copy it, unless I enable web developer tools and copy it from the source of the page.

It's really a terrible user experience.


Maybe you could tell me that, I could copy it from the "View data as" page, but it only can copy the reverse format of the transaction page displayed.

I have tried all formats in "View data as" page.


Suggestions

Give users an option to disable these features.1

You can save the user preferences in the browser storage or cache.

Footnotes

  1. An good example is Rust std docs.

@yangby-cryptape yangby-cryptape added the help wanted Extra attention is needed label Apr 14, 2024
@yangby-cryptape
Copy link
Author

yangby-cryptape commented Apr 14, 2024

Another terrible user experience: When I search an args in the explorer (I tried with Firefox, I guess Chrome is the same), a window always pops up automatically, and hide the content I searched behind the window.

@Keith-CY
Copy link
Collaborator

Description

I want to copy the lock script args and go to another page to search this args, to make sure they are the same args.

But, after the upgrade in last week (maybe two weeks ago, I guess).

When I select the args, I could NOT copy it, unless I enable web developer tools and copy it from the source of the page.

It's really a terrible user experience.

Maybe you could tell me that, I could copy it from the "View data as" page, but it only can copy the reverse format of the transaction page displayed.

I have tried all formats in "View data as" page.

Suggestions

Give users an option to disable these features.1

You can save the user preferences in the browser storage or cache.

Footnotes

  1. An good example is Rust std docs.

Hi @yangby-cryptape
Could you show me where you were trying to copy the lock_script.args, because I can copy the args in script dialog by cmd + k and copy in right-click menu

image

It's probably a compatibility issue so it would be great if you could share the platform info.

BTW, a dashboard with settings(Magickbase/ckb-explorer-public-issues#582) will be enabled later, I will add disable decoder in it.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Apr 14, 2024

Description

I want to copy the lock script args and go to another page to search this args, to make sure they are the same args.
But, after the upgrade in last week (maybe two weeks ago, I guess).
When I select the args, I could NOT copy it, unless I enable web developer tools and copy it from the source of the page.
It's really a terrible user experience.
Maybe you could tell me that, I could copy it from the "View data as" page, but it only can copy the reverse format of the transaction page displayed.
I have tried all formats in "View data as" page.

Suggestions

Give users an option to disable these features.1
You can save the user preferences in the browser storage or cache.

Footnotes

  1. An good example is Rust std docs.

Hi @yangby-cryptape Could you show me where you were trying to copy the lock_script.args, because I can copy the args in script dialog by cmd + k and copy in right-click menu

image It's probably a compatibility issue so it would be great if you could share the platform info.

BTW, a dashboard with settings(Magickbase/ckb-explorer-public-issues#582) will be enabled later, I will add disable decoder in it.

I got. Now you can double-click the args to select the string. @yangby-cryptape it's a bit tricky and I will fix it soon

@Keith-CY
Copy link
Collaborator

Another terrible user experience: When I search an args in the explorer (I tried with Firefox, I guess Chrome is the same), a window always pops up automatically, and hide the content I searched behind the window.

Can you share a screenshot of how the result is overlapped by the new window

@yangby-cryptape
Copy link
Author

yangby-cryptape commented Apr 15, 2024

Can you share a screenshot of how the result is overlapped by the new window

  • After I input Ctrl+F (search) in Firefox or Chromium, a search bar (belongs to the browser) will pop up.

  • Then I Ctrl+V (paste) the args input the search bar, then the "View data as" page will pop up.

  • I got. Now you can double-click the args to select the string.

    • Before you fixed this, the "View data as" page will just overlap the args.

    • Now, after you fixed this, the "View data as" page is far away from the args.

  • So, I think this bug is fixed too.

For my personal use case, I think you can close this issue as completed.

@Keith-CY
Copy link
Collaborator

Can you share a screenshot of how the result is overlapped by the new window

  • After I input Ctrl+F (search) in Firefox or Chromium, a search bar (belongs to the browser) will pop up.

  • Then I Ctrl+V (paste) the args input the search bar, then the "View data as" page will pop up.

  • I got. Now you can double-click the args to select the string.

    • Before you fixed this, the "View data as" page will just overlap the args.
    • Now, after you fixed this, the "View data as" page is far away from the args.
  • So, I think this bug is fixed too.

For my personal use case, I think you can close this issue as completed.

Glad to know that the decoder dialog doesn't obstruct interaction on the text in some cases. I just pushed another update to keep the dialog next to the selected text, you may have a try.

I will close this issue if the new position of the dialog works for you.

@yangby-cryptape
Copy link
Author

I will close this issue if the new position of the dialog works for you.

Checked! Passed!

Click to see the test result.

Press Ctrl+F in Firefox and use Ctrl+V to paste the args string into the search bar:

Search args in Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants