Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PackageVariantSet v1alpha2 #99

Closed
gvbalaji opened this issue Apr 8, 2023 · 8 comments
Closed

Implement PackageVariantSet v1alpha2 #99

gvbalaji opened this issue Apr 8, 2023 · 8 comments
Assignees
@johnbelamaric
Labels
area/package-management SIG Automation Package Management Subproject sig/automation
Milestone
sprint4

Comments

@gvbalaji
Copy link

gvbalaji commented Apr 8, 2023

This needs to be TBD. Most likely upstream porch work.
function pipeline in PackageVariant/PackageVariantSet
Unit test coverage
@gvbalaji gvbalaji added area/package-management SIG Automation Package Management Subproject sig/automation labels Apr 8, 2023
@gvbalaji gvbalaji added this to the sprint2 milestone Apr 8, 2023
@gvbalaji gvbalaji moved this to Todo in Nephio R1 Apr 8, 2023
@gvbalaji gvbalaji modified the milestones: sprint2, sprint3 Apr 11, 2023
@johnbelamaric
Copy link
Member

/retitle Implement PackageVariantSet v1alpha2

The current v1alpha1 does not support any of the new PackageVariant features such as pipeline editing, package context editing, and config injection.

See the updated design proposal https://github.com/GoogleContainerTools/kpt/blob/main/docs/design-docs/08-package-variant.md

See also #43 and #117.

@johnbelamaric
Copy link
Member

/retitle Implement PackageVariantSet v1alpha2

@johnbelamaric
Copy link
Member

Weird, I thought I used that before in this repo and it worked. @radoslawc is Prow OK?

@johnbelamaric johnbelamaric changed the title Implement function pipeline in PackageVariant/PackageVariantSet Implement PackageVariantSet v1alpha2 Apr 25, 2023
@johnbelamaric johnbelamaric moved this from Todo to In Progress in Nephio R1 Apr 25, 2023
@johnbelamaric
Copy link
Member

Got started on this. See kptdev/kpt#3930

@radoslawc
Copy link
Contributor

Weird, I thought I used that before in this repo and it worked. @radoslawc is Prow OK?

@johnbelamaric it did work, I've used it few times. I'll look into that.

@radoslawc radoslawc mentioned this issue Apr 26, 2023
Merged
@johnbelamaric
Copy link
Member

Latest status: kptdev/kpt#3930 is almost ready for review. Just need to setup, run, and configure the conversion webhooks.

@johnbelamaric
Copy link
Member

Probably going to skip the conversion webhooks. So, ready for review. kptdev/kpt#3930

@gvbalaji gvbalaji modified the milestones: sprint3, sprint4 May 9, 2023
@johnbelamaric
Copy link
Member

PR has merged.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Nephio R1 May 10, 2023
@johnbelamaric johnbelamaric mentioned this issue May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnbelamaric johnbelamaric

Labels
area/package-management SIG Automation Package Management Subproject sig/automation
Projects
Nephio R1
Status: Done
Milestone
sprint4
Development

No branches or pull requests
3 participants
@radoslawc @gvbalaji @johnbelamaric