-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIGKILL when run nvim executable during make
with Apple Clang
#13399
Comments
make
on Apple Silicon (arm64)
Hard to tell what's going on without having the whole compilation log. Could you upload it somewhere? |
On first sight, the binary looks fine.
|
@glacambre, sure - neovim_m1_make.log. |
Running into the same issue here, though no on an M1. $ make
cd .deps && \
cmake -G 'Ninja' \
/Users/mhartington/Github/neovim-org/neovim/third-party
-- Found GNU Make at /usr/bin/make
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/mhartington/Github/neovim-org/neovim/.deps
mkdir -p build
touch build/.ran-third-party-cmake
ninja -C .deps
ninja: Entering directory `.deps'
[3/3] cd /Users/mhartington/Github/neovim-org/neovim/.deps && /usr/local/Cellar/cmake/3.18.1/bin/cmake -E touch .third-party
cd build && cmake -G 'Ninja' -DCMAKE_BUILD_TYPE=Debug /Users/mhartington/Github/neovim-org/neovim
-- The C compiler identification is AppleClang 12.0.0.12000032
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- CMAKE_INSTALL_PREFIX=/usr/local
-- CMAKE_BUILD_TYPE=Debug
-- MIN_LOG_LEVEL not specified, default is 1 (INFO)
-- Replacing -O3 in CMAKE_C_FLAGS_RELEASE with -O2
-- Performing Test HAS_ACCEPTABLE_FORTIFY
-- Performing Test HAS_ACCEPTABLE_FORTIFY - Failed
-- Unsupported _FORTIFY_SOURCE found, forcing _FORTIFY_SOURCE=1
-- Performing Test HAVE_EXECINFO_BACKTRACE
-- Performing Test HAVE_EXECINFO_BACKTRACE - Success
-- Performing Test HAVE_BUILTIN_ADD_OVERFLOW
-- Performing Test HAVE_BUILTIN_ADD_OVERFLOW - Success
-- Performing Test HAVE_WIMPLICIT_FALLTHROUGH_FLAG
-- Performing Test HAVE_WIMPLICIT_FALLTHROUGH_FLAG - Success
-- Performing Test HAS_WVLA_FLAG
-- Performing Test HAS_WVLA_FLAG - Success
-- Performing Test HAS_FSTACK_PROTECTOR_STRONG_FLAG
-- Performing Test HAS_FSTACK_PROTECTOR_STRONG_FLAG - Success
-- Performing Test HAS_FSTACK_PROTECTOR_FLAG
-- Performing Test HAS_FSTACK_PROTECTOR_FLAG - Success
-- Performing Test HAVE_FNO_COMMON
-- Performing Test HAVE_FNO_COMMON - Success
-- Performing Test HAS_DIAG_COLOR_FLAG
-- Performing Test HAS_DIAG_COLOR_FLAG - Success
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Looking for dlopen in dl
-- Looking for dlopen in dl - found
-- Looking for kstat_lookup in kstat
-- Looking for kstat_lookup in kstat - not found
-- Looking for kvm_open in kvm
-- Looking for kvm_open in kvm - not found
-- Looking for gethostbyname in nsl
-- Looking for gethostbyname in nsl - not found
-- Looking for perfstat_cpu in perfstat
-- Looking for perfstat_cpu in perfstat - not found
-- Looking for clock_gettime in rt
-- Looking for clock_gettime in rt - not found
-- Looking for sendfile in sendfile
-- Looking for sendfile in sendfile - not found
-- Found LibUV: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/lib/libuv.a (Required is at least version "1.28.0")
-- Found Msgpack: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/lib/libmsgpackc.a (found suitable version "3.0.0", minimum required is "1.0.0")
-- Found LibLUV: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/lib/libluv.a (Required is at least version "1.30.0")
-- Found TreeSitter 0.6.3
-- Found LuaJit: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/lib/libluajit-5.1.a
-- Performing Test MSGPACK_HAS_FLOAT32
-- Performing Test MSGPACK_HAS_FLOAT32 - Success
-- Found UNIBILIUM 2.0.0
-- Performing Test UNIBI_HAS_VAR_FROM
-- Performing Test UNIBI_HAS_VAR_FROM - Success
-- Found LibTermkey: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/lib/libtermkey.a (Required is at least version "0.18")
-- Found LIBVTERM 0.1.4
-- Found Iconv
-- Performing Test HAVE_WORKING_LIBINTL
-- Performing Test HAVE_WORKING_LIBINTL - Success
-- Looking for _nl_msg_cat_cntr
-- Looking for _nl_msg_cat_cntr - not found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Checking Lua interpreter: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/bin/luajit
-- Using Lua interpreter: /Users/mhartington/Github/neovim-org/neovim/.deps/usr/bin/luajit
-- Performing Test HAS_WSTATIC_IN_INLINE
-- Performing Test HAS_WSTATIC_IN_INLINE - Success
-- Using NVIM_VERSION_MEDIUM from Git
-- Found Gettext: /usr/local/opt/gettext/bin/msgmerge (found version "0.21")
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of int
-- Check size of int - done
-- Check size of long
-- Check size of long - done
-- Check size of intmax_t
-- Check size of intmax_t - done
-- Check size of size_t
-- Check size of size_t - done
-- Check size of long long
-- Check size of long long - done
-- Check size of void *
-- Check size of void * - done
-- Looking for _NSGetEnviron
-- Looking for _NSGetEnviron - found
-- Looking for include file langinfo.h
-- Looking for include file langinfo.h - found
-- Looking for include file locale.h
-- Looking for include file locale.h - found
-- Looking for include file pwd.h
-- Looking for include file pwd.h - found
-- Looking for include file strings.h
-- Looking for include file strings.h - found
-- Looking for include file sys/wait.h
-- Looking for include file sys/wait.h - found
-- Looking for include file sys/utsname.h
-- Looking for include file sys/utsname.h - found
-- Looking for include file termios.h
-- Looking for include file termios.h - found
-- Looking for include file sys/uio.h
-- Looking for include file sys/uio.h - found
-- Looking for include file sys/sdt.h
-- Looking for include file sys/sdt.h - found
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for getpwent
-- Looking for getpwent - found
-- Looking for getpwnam
-- Looking for getpwnam - found
-- Looking for getpwuid
-- Looking for getpwuid - found
-- Looking for readv
-- Looking for readv - found
-- Looking for opendir
-- Looking for opendir - found
-- Looking for readlink
-- Looking for readlink - found
-- Looking for setpgid
-- Looking for setpgid - found
-- Looking for setsid
-- Looking for setsid - found
-- Looking for sigaction
-- Looking for sigaction - found
-- Looking for strcasecmp
-- Looking for strcasecmp - found
-- Looking for strncasecmp
-- Looking for strncasecmp - found
-- Looking for FD_CLOEXEC
-- Looking for FD_CLOEXEC - found
-- Looking for CODESET
-- Looking for CODESET - found
-- Looking for include file endian.h
-- Looking for include file endian.h - not found
-- Looking for include file sys/endian.h
-- Looking for include file sys/endian.h - not found
-- Performing Test HAVE_BE64TOH_MACROS
-- Performing Test HAVE_BE64TOH_MACROS - Failed
-- Looking for be64toh
-- Looking for be64toh - not found
-- Performing Test ORDER_BIG_ENDIAN
-- Performing Test ORDER_BIG_ENDIAN - Failed
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/mhartington/Github/neovim-org/neovim/build
touch build/.ran-cmake
ninja -C build
ninja: Entering directory `build'
[315/319] Linking C executable bin/nvim
ld: warning: dylib (/usr/local/opt/gettext/lib/libintl.dylib) was built for newer macOS version (10.15) than being linked (10.14)
[317/319] Generating pack/dist/opt/matchit/doc/tags
FAILED: runtime/pack/dist/opt/matchit/doc/tags
cd /Users/mhartington/Github/neovim-org/neovim/build/runtime/pack/dist/opt/matchit && /usr/local/Cellar/cmake/3.18.1/bin/cmake -E copy_directory /Users/mhartington/Github/neovim-org/neovim/runtime/pack/dist/opt/matchit /Users/mhartington/Github/neovim-org/neovim/build/runtime/pack/dist/opt/matchit && /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ doc -c quit
/bin/sh: line 1: 54817 Abort trap: 6 /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ doc -c quit
[318/319] Generating pack/dist/opt/vimball/doc/tags
FAILED: runtime/pack/dist/opt/vimball/doc/tags
cd /Users/mhartington/Github/neovim-org/neovim/build/runtime/pack/dist/opt/vimball && /usr/local/Cellar/cmake/3.18.1/bin/cmake -E copy_directory /Users/mhartington/Github/neovim-org/neovim/runtime/pack/dist/opt/vimball /Users/mhartington/Github/neovim-org/neovim/build/runtime/pack/dist/opt/vimball && /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ doc -c quit
/bin/sh: line 1: 54816 Abort trap: 6 /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ doc -c quit
[319/319] Generating doc/tags
FAILED: runtime/doc/tags
cd /Users/mhartington/Github/neovim-org/neovim/build/runtime && /usr/local/Cellar/cmake/3.18.1/bin/cmake -E remove doc/* && /usr/local/Cellar/cmake/3.18.1/bin/cmake -E copy_directory /Users/mhartington/Github/neovim-org/neovim/runtime/doc doc && /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ ++t\ doc -c quit
/bin/sh: line 1: 54818 Abort trap: 6 /Users/mhartington/Github/neovim-org/neovim/build/bin/nvim -u NONE -i NONE -e --headless -c helptags\ ++t\ doc -c quit
ninja: build stopped: subcommand failed.
make: *** [nvim] Error 1 Haven't changed my setup at all, just pulled in a few new commits so thinking the culprit is in there. EDIT Looks like 72d2984 is the culprit for me. @dive can you try to build from master at |
@mhartington, does not work as well, with the same problem
I can try to run bisect later today or tomorrow, will take some time. |
That commit changes nothing. Except LTO quantum effects i suppose. |
@mhartington I can reproduce this on master, but only with a Line 497 in d956842
(Doesn't explain why it's SIGKILLed, of course...) |
@clason couldn't get Release/RelWithDebInfo to work either, but once line 497 in option.c is commented out, all works fine. |
@clason, I follow the instruction to building Neovim, nothing fancy: checkout the master branch, install dependencies, run
About #12624, I can confirm that it compiles just fine with the following steps:
I tried to comment out the line, does not help either on |
@dive there are two different issues here:
Do you still observe the crash when both building with the PR and with that line removed? |
The build from the #12624 works just fine by default, but it has an outdated master without these recent changes you are talking about. I pulled the master locally, and yeah, can confirm that the crash is there for the Debug configuration: With
With commented out
|
@dive Thanks for confirming (I cannot test Apple silicon myself). So the root problem is a regression introduced by 72d2984 with Apple I'll have to leave the question how to best fix it to @bfredl... |
make
on Apple Silicon (arm64)make
with Apple Clang
@clason, glad to help. I have changed the title and description. |
Can you try building with ASAN enabled and see if that provides a hint to what's going on?
|
That leaves an empty log file? |
Only if ASAN doesn't detect anything. :) |
So I guess it didn't ;) |
Is there a complete traceback? it should already just skip logging if log file cannot be opened but there could be subtle difference in behavior between libc implementations.. |
|
That's what I wanted to hear (the rest was expected), thank you! I'll close this issue now; the other PR with Apple Silicon support will get merged once the fallout from the needed dependency bump is sorted out. |
nvim --version
: Not availablevim -u DEFAULTS
(version: ) behaves differently?: Not available$TERM
: shell v3.1.2, xterm-256color-On Mac Mini M1 (Apple Silicon)- Does not relate to the issue.
Steps to reproduce using
nvim -u NORC
make
Actual behaviour
Compilation failed due to
SIGKILL
onnvim
executable launch:The
nvim
executable is there, but it fails withSIGKILL
when you try to run it:Expected behaviour
The executable works as expected.
The text was updated successfully, but these errors were encountered: