We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With 8.2 we switched to css grid With #3366 (unreleased 8.3) the css grid identifiers declared here:
neos-ui/packages/neos-ui/src/Containers/style.module.css
Line 8 in e4080d6
neos-ui/packages/neos-ui/src/Containers/RightSideBar/style.module.css
Line 2 in e4080d6
Line 24 in e4080d6
as proposed here: parcel-bundler/lightningcss#144 (comment)
css-modules/css-modules#390
The text was updated successfully, but these errors were encountered:
I had a similar issue in the media ui and when putting the areas and references into css variables, it works and keeps the names intact.
Which is actually even nicer for extensibility.
Example:
.container { --grid-areas: "left top right" "left main right"; --grid-area-right: right; grid-template-areas: var(--grid-areas); } .gridRight { grid-area: var(--grid-area-right); }
Sorry, something went wrong.
nice trick ^^ (makes sense that you had the same problem as youre also using parcels lightning css under the hood?)
so yes im fine with implementing it like this.
otherwise we could also do:
some global css file:
.my-css-grid { grid-template-areas: "left top right" "left main right"; } .my-css-grid-right { grid-area: right; }
.container { composes: my-css-grid from global; } .gridRight { composes: my-css-grid-right from global; }
No branches or pull requests
Description
With 8.2 we switched to css grid
With #3366 (unreleased 8.3) the css grid identifiers declared here:
neos-ui/packages/neos-ui/src/Containers/style.module.css
Line 8 in e4080d6
will be scoped to the css module (and the are name will obscurified)
thats why we use composition to apply the grid-area property:
neos-ui/packages/neos-ui/src/Containers/RightSideBar/style.module.css
Line 2 in e4080d6
neos-ui/packages/neos-ui/src/Containers/style.module.css
Line 24 in e4080d6
as proposed here: parcel-bundler/lightningcss#144 (comment)
Fyi, there is now an proposal in css-modules for global css grid identifier:
css-modules/css-modules#390
The text was updated successfully, but these errors were encountered: